Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid support #6

Open
jalberto opened this issue Jul 15, 2020 · 1 comment
Open

Liquid support #6

jalberto opened this issue Jul 15, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@jalberto
Copy link

Will be great to have Liquid support as well as NJK

Thanks for your work!

@KyleMit KyleMit added the enhancement New feature or request label Aug 19, 2020
@KyleMit
Copy link
Owner

KyleMit commented Aug 19, 2020

Seems totally reasonable. The lookups are using async/await, so we're bound to shortcode templating languages that have async support.

Should be available in:

We have to register each language individually, but shouldn't take too much work to add to the .eleventy.js file like this:

eleventyConfig.addNunjucksAsyncShortcode("tweet", async(tweetId) => {
    return await twitter.getTweet(tweetId, options)
});

Thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants