Updates in CRUD

Author: KunjManavadariya

Ideaboard/controllers/userControllers.js

@@ -1,38 +1,32 @@
 import jwt from "jsonwebtoken";
 import md5 from "md5";
 import env from "dotenv";
-import { conn, client } from "../db";
-let db;
-conn().then(async () => {
-  db = await client().db("ideaboard");
-});
-
+import { db } from "../db";
+import { ObjectID } from "bson";
+import {
+  getAllUsers,
+  delUser,
+  findUserById,
+  IsUnique,
+  updateUserDetails,
+} from "../database/userQueries";
+import { badRequest } from "../errors/badRequest";
+import { genError } from "../errors/generalError";
 env.config();
 
-export const users = [];
-export const message = function (success, text) {
-  return { success: success, message: text };
-};
-
-export const allUsers = async (ctx) => {
-  const res = await users.map((user) => {
-    const { username, email, boards, joined_at } = user;
-    return { username, email, boards, joined_at };
-  });
-  ctx.body = res;
-};
+export const message = (success, text) => ({ success, message: text });
 
 export const newUser = async (ctx) => {
   const user = ctx.request.body;
   user.joined_at = new Date(new Date().getTime() + 19800000);
   user.boards = [];
-  const hash = await md5(user.password);
-  user.password = hash;
-  await db.insertOne(user);
-  ctx.body = message(
-    true,
-    `Successfully registered a new user with username ${user.username}!`
-  );
+  const hash = md5(user.password);
+  hash && (user.password = hash);
+  (await db.collection("users").insertOne(user)) &&
+    (ctx.body = {
+      success: true,
+      message: "Successfully inserted user.",
+    });
 };
 
 export const loginUser = async (ctx) => {
@@ -41,36 +35,42 @@ export const loginUser = async (ctx) => {
     expiresIn: "20m",
   });
   ctx.body = message(true, "Successfully logged you in!");
-  ctx.body.token = token;
+  token && (ctx.body.token = token);
+};
+
+export const allUsers = async (ctx) => {
+  const data = await getAllUsers();
+  data
+    ? (ctx.body = data)
+    : genError(ctx, "Can't fetch users. Try again later.");
 };
 
 export const updateUser = async (ctx) => {
-  const id = ctx.params.id;
+  const id = ctx.request.params.id;
   const updUser = ctx.request.body;
-  const foundUser = users.find((user) => user.username === id);
+  const foundUser = await findUserById(id);
   if (!foundUser) {
     ctx.status = 400;
     ctx.body = message(false, "No user found with given ID!");
     return;
   }
-  if (foundUser.email === updUser.email) {
-  }
-  foundUser.username = updUser.username;
-  foundUser.email = updUser.email;
-  foundUser.password = updUser.password;
-  ctx.body = message(true, "Successfully updated user details");
+  (await IsUnique(
+    new ObjectID(updUser._id),
+    updUser.username,
+    updUser.email,
+    ctx
+  )) &&
+    updateUserDetails(new ObjectID(updUser._id), updUser) &&
+    (ctx.body = message(true, "Successfully updated user details"));
 };
 
 export const deleteUser = async (ctx) => {
   const id = ctx.request.params.id;
-  const foundUser = users.find((user) => {
-    return user.username === id;
-  });
+  const foundUser = await findUserById(id);
   if (!foundUser) {
-    ctx.status = 400;
-    ctx.body = message(false, "No user found with given ID!");
+    badRequest(ctx, "No user found with given ID!");
     return;
   }
-  users.splice(users.indexOf(foundUser), 1);
-  ctx.body = message(true, `Successfully deleted the user with id ${id}!`);
+  (await delUser(id)) &&
+    (ctx.body = message(true, `Successfully deleted the user with id ${id}!`));
 };

Ideaboard/database/userQueries.js

@@ -0,0 +1,45 @@
+import { db } from "../db";
+
+export const isUser = async (email, username) =>
+  await db.collection("users").findOne({ $and: [{ email }, { username }] });
+
+export const userExists = async (email, username) =>
+  await db.collection("users").findOne({ $or: [{ email }, { username }] });
+
+export const findUserById = async (id) =>
+  await db.collection("users").findOne({ username: id });
+
+export const getAllUsers = async () =>
+  await db
+    .collection("users")
+    .find({}, { projection: { password: 0 } })
+    .toArray();
+
+export const IsUnique = async (userId, updatedUsername, updatedEmail, ctx) => {
+  const user = await db.collection("users").findOne({
+    $and: [
+      { $or: [{ username: updatedUsername }, { email: updatedEmail }] },
+      { _id: { $ne: userId } },
+    ],
+  });
+  if (user) {
+    ctx.status = 400;
+    ctx.body = {
+      success: false,
+      message: "User with these credentials already exists.",
+    };
+    return;
+  }
+  return true;
+};
+
+export const updateUserDetails = async (userId, updatedUser) => {
+  delete updatedUser._id &&
+    (await db
+      .collection("users")
+      .updateOne({ _id: userId }, { $set: updatedUser }));
+  return;
+};
+
+export const delUser = async (id) =>
+  await db.collection("users").deleteOne({ username: id });

Ideaboard/db.js

@@ -1,12 +1,24 @@
-import * as mongodb from "mongodb";
+import { MongoClient } from "mongodb";
 
-const MongoClient = mongodb.MongoClient;
 const uri = "mongodb://localhost:27017/";
-export const client = new MongoClient(uri);
-export const conn = async function () {
-  try {
+
+let client, db;
+
+async function connectToDb() {
+  if (!client) {
+    client = new MongoClient(uri, { useNewUrlParser: true });
     await client.connect();
-  } catch (err) {
-    console.log(err);
+    db = client.db("ideaboard");
   }
-};
+  return client;
+}
+
+connectToDb()
+  .then(() => {
+    console.log("Database Connected...");
+  })
+  .catch((err) => {
+    console.log(err);
+  });
+
+export { db };

Ideaboard/errors/badRequest.js

@@ -0,0 +1,4 @@
+export const badRequest = (ctx, message) => {
+  ctx.status = 400;
+  ctx.body = { success: false, message };
+};

Ideaboard/errors/generalError.js

@@ -0,0 +1,4 @@
+export const genError = async () => (ctx, message) => {
+  ctx.status = 408;
+  ctx.body = { success: false, message };
+};

Ideaboard/errors/unauthorized.js

@@ -0,0 +1,4 @@
+export const unauthorized = (ctx, message) => {
+  ctx.status = 401;
+  ctx.body = { success: false, message };
+};

Ideaboard/index.js

@@ -1,21 +1,14 @@
 import Koa from "koa";
 import bodyParser from "koa-bodyparser";
 import { router } from "./routes/userRoutes";
-const { conn, client } = require("./db");
 const app = new Koa();
 
-app.use(bodyParser()).use(router.routes()).use(router.allowedMethods());
+app.use(bodyParser());
 
-conn();
+app.use(router.routes()).use(router.allowedMethods());
 
-client
-  .db("ideaboard")
-  .then(() => {
-    console.log("Database Connected!");
-    app.listen(3000, () => {
-      console.log("Server running on http://localhost:3000");
-    });
-  })
-  .catch((err) => {
-    console.log(err);
-  });
+app.listen(3000, () => {
+  console.log("Server running on http://localhost:3000");
+});
+
+export default app;

Ideaboard/middlewares.js

@@ -1,60 +1,70 @@
 import md5 from "md5";
-import { users, message } from "./controllers/userControllers";
 import jwt from "jsonwebtoken";
+import { isUser, userExists } from "./database/userQueries";
+import { unauthorized } from "./errors/unauthorized";
+import { badRequest } from "./errors/badRequest";
 
-export const verifyLogin = async function (ctx, next) {
+export const verifyUser = (ctx, next) => {
+  if (!ctx.request.headers.authorization) {
+    unauthorized(ctx, "Unauthorized request");
+    return;
+  }
+  const token = ctx.request.headers.authorization.split(" ")[1];
+  if (!token) {
+    unauthorized(ctx, "Access denied. No token provided.");
+    return;
+  }
+  try {
+    const decoded = jwt.verify(token, process.env.JWT_SECRET);
+    ctx.request.user = decoded.user;
+    return next();
+  } catch (err) {
+    unauthorized(ctx, "Invalid token");
+    return;
+  }
+};
+
+export const verifyLogin = async (ctx, next) => {
   const user = ctx.request.body;
   if (!user.username || !user.email || !user.password) {
-    ctx.status = 400;
-    ctx.body = message(
-      false,
-      "Provide username, email, and password to login!"
-    );
+    badRequest(ctx, "Provide username, email, and password to login!");
     return;
   }
   const { username, email, password } = user;
-  const foundUser = users.find((user) => {
-    return user.email === email && user.username === username;
-  });
+  const foundUser = await isUser(email, username);
   if (!foundUser) {
-    ctx.status = 400;
-    ctx.body = message(false, "Invalid username, email or password!");
+    badRequest(ctx, "Invalid username, email or password!");
     return;
   }
-  const isPasswordValid = (await md5(password)) === foundUser.password;
+  const isPasswordValid = md5(password) === foundUser.password;
   if (!isPasswordValid) {
-    ctx.status = 400;
-    ctx.body = message(false, "Invalid username, email or password!");
+    badRequest(ctx, "Invalid username, email or password!");
     return;
   }
-  await next();
+  return next();
 };
 
-export const verifyUserDuplicates = function (ctx, next) {
+export const verifyUserDuplicates = async (ctx, next) => {
   const { email, password, username } = ctx.request.body;
   if (!email || !password) {
-    ctx.status = 400;
-    ctx.body = { success: false, message: "Email and password are required." };
+    badRequest(ctx, "Email and password are required.");
     return;
   }
   if (!username) {
-    ctx.status = 400;
-    ctx.body = { success: false, message: "Username is required." };
+    badRequest(ctx, "Username is required.");
     return;
   }
   if (
-    users.find((ele) => {
-      return ele.email === email || ele.username === username;
-    })
+    (await userExists(email, username)) ||
+    badRequest(ctx, "Seomething went wrong. Try again after some time.")
   ) {
-    ctx.status = 400;
-    ctx.body = message(
-      false,
+    badRequest(
+      ctx,
       "User with these credentials already exists. Provide a different username or email!"
     );
     return;
   }
-  next();
+  return next();
 };
 
 export const verifyUserRegex = (ctx, next) => {
@@ -63,45 +73,18 @@ export const verifyUserRegex = (ctx, next) => {
     /^[a-zA-Z0-9.!#$%&'*+/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*$/;
   const usernameRegex = /^[a-zA-Z0-9._]{4,15}$/;
   if (!usernameRegex.test(username)) {
-    ctx.status = 400;
-    ctx.body = {
-      success: false,
-      message:
-        "Username must be 4 to 15 characters long and should not contain any special characters!",
-    };
+    badRequest(
+      ctx,
+      "Username must be 4 to 15 characters long and should not contain any special characters!"
+    );
     return;
   }
   if (!emailRegex.test(email) || password.length < 8 || password.length > 15) {
-    ctx.status = 400;
-    ctx.body = {
-      success: false,
-      message:
-        "Email or password is in incorrect format. Check email format and password must be at least 8 characters long.",
-    };
-    return;
-  }
-  next();
-};
-
-export const verifyUser = function (ctx, next) {
-  if (!ctx.request.headers.authorization) {
-    ctx.status = 401;
-    ctx.body = "Unauthorized request!";
-    return;
-  }
-  const token = ctx.request.headers.authorization.split(" ")[1];
-  if (!token) {
-    ctx.status = 401;
-    ctx.body = "Access denied. No token provided.";
-    return;
-  }
-  try {
-    const decoded = jwt.verify(token, process.env.JWT_SECRET);
-    ctx.request.user = decoded.user;
-    next();
-  } catch (err) {
-    ctx.status = 400;
-    ctx.body = "Invalid token";
+    badRequest(
+      ctx,
+      "Email or password is in incorrect format. Check email format and password must be at least 8 characters long."
+    );
     return;
   }
+  return next();
 };