Merge pull request #121 from jsmolar/metadata

Move Mockserver fixture to higher conftest

Author: pehala

testsuite/mockserver.py

@@ -27,7 +27,7 @@ def create_expectation(self, expectation_id, path, opa_policy):
                 }
             )
         response.raise_for_status()
-        return response
+        return self.url + path
 
     def clear_expectation(self, expectation_id):
         """Clears Expectation with specific ID"""

testsuite/tests/conftest.py

@@ -4,8 +4,10 @@
 from urllib.parse import urlparse
 
 import pytest
+from dynaconf import ValidationError
 from keycloak import KeycloakAuthenticationError
 
+from testsuite.mockserver import Mockserver
 from testsuite.oidc import OIDCProvider
 from testsuite.config import settings
 from testsuite.oidc.auth0 import Auth0Provider
@@ -82,6 +84,16 @@ def auth0(testconfig):
         return pytest.skip(f"Auth0 configuration item is missing: {exc}")
 
 
+@pytest.fixture(scope="module")
+def mockserver(testconfig):
+    """Returns mockserver"""
+    try:
+        testconfig.validators.validate(only=["mockserver"])
+        return Mockserver(testconfig["mockserver"]["url"])
+    except (KeyError, ValidationError) as exc:
+        return pytest.skip(f"Mockserver configuration item is missing: {exc}")
+
+
 @pytest.fixture(scope="session")
 def oidc_provider(rhsso) -> OIDCProvider:
     """Fixture which enables switching out OIDC providers for individual modules"""

testsuite/tests/kuadrant/authorino/authorization/opa/conftest.py

@@ -0,0 +1,27 @@
+"""Conftest for OPA policy located on external registry"""
+import pytest
+
+from testsuite.utils import rego_allow_header
+
+
+@pytest.fixture(scope="module")
+def header():
+    """Header used by OPA policy"""
+    return "opa", "opa-test"
+
+
+@pytest.fixture(scope="module")
+def opa_policy_expectation(request, mockserver, module_label, header):
+    """Creates Mockserver Expectation that returns Rego query and returns its endpoint"""
+    request.addfinalizer(lambda: mockserver.clear_expectation(module_label))
+    return mockserver.create_expectation(module_label, f"/{module_label}/opa", rego_allow_header(*header))
+
+
+@pytest.fixture(scope="module")
+def authorization(authorization, opa_policy_expectation):
+    """
+    Adds OPA policy. Rego query is located on external registry (Mockserver).
+    Policy accepts requests that contain `header`.
+    """
+    authorization.add_external_opa_policy("opa", opa_policy_expectation, 1)
+    return authorization

testsuite/tests/kuadrant/authorino/authorization/opa/external_registry/__init__.py

@@ -18,21 +18,11 @@ def updated_header():
 @pytest.fixture(scope="module", autouse=True)
 def update_external_opa(mockserver, module_label, updated_header):
     """Updates Expectation with updated header"""
-    mockserver.create_expectation(module_label, "/opa", rego_allow_header(*updated_header))
+    mockserver.create_expectation(module_label, f"/{module_label}/opa", rego_allow_header(*updated_header))
     # Sleeps for 1 second to compensate auto-refresh cycle `authorization.opa.externalRegistry.ttl = 1`
     time.sleep(1)
 
 
-@pytest.fixture(scope="module")
-def authorization(authorization, mockserver):
-    """
-    Adds OPA policy. Rego query is located on external registry (Mockserver).
-    Policy accepts requests that contain `header`.
-    """
-    authorization.add_external_opa_policy("opa", mockserver.url + "/opa", 1)
-    return authorization
-
-
 def test_auto_refresh(client, auth, updated_header):
     """Tests auto-refresh of OPA policy from external registry."""
     key, value = updated_header

testsuite/tests/kuadrant/authorino/authorization/opa/external_registry/conftest.py

@@ -1,17 +1,5 @@
 """Tests for Open Policy Agent (OPA) using Mockserver Expectations as http endpoint with Rego query"""
 
-import pytest
-
-
-@pytest.fixture(scope="module")
-def authorization(mockserver, authorization):
-    """
-    Adds OPA policy. Rego query is located on external registry (Mockserver).
-    Policy accepts requests that contain `header`.
-    """
-    authorization.add_external_opa_policy("opa", mockserver.url + "/opa")
-    return authorization
-
 
 def test_allowed_by_opa(client, auth, header):
     """Tests a request that should be authorized by OPA external registry declaration"""

testsuite/tests/kuadrant/authorino/authorization/opa/test_auto_refresh_policy.py testsuite/tests/kuadrant/authorino/authorization/opa/external_registry/test_auto_refresh_policy.py

@@ -4,6 +4,12 @@
 from testsuite.utils import rego_allow_header
 
 
+@pytest.fixture(scope="module")
+def header():
+    """Header used by OPA policy"""
+    return "opa", "opa-test"
+
+
 @pytest.fixture(scope="module")
 def authorization(authorization, header):
     """Adds OPA policy that accepts all requests that contain `header`"""