Skip to content
This repository was archived by the owner on Nov 8, 2022. It is now read-only.

RateLimitPolicy add Gateway API policy attachment (target ref) #121

Closed
8 of 9 tasks
maleck13 opened this issue Mar 24, 2022 · 5 comments
Closed
8 of 9 tasks

RateLimitPolicy add Gateway API policy attachment (target ref) #121

maleck13 opened this issue Mar 24, 2022 · 5 comments
Assignees
Labels
kind/epic target/current Current work sprint
Milestone

Comments

@maleck13
Copy link
Contributor

maleck13 commented Mar 24, 2022

To bring the Rate Limit Policy API in line with the policy attachment concept from Gateway API, we need to add a target ref We also need to consider support default and override along with the inheritance model.

// PolicyTargetReference identifies an API object to apply policy to.
type PolicyTargetReference struct {
    // Group is the group of the target resource.
    //
    // +kubebuilder:validation:MinLength=1
    // +kubebuilder:validation:MaxLength=253
    Group string `json:"group"`

    // Kind is kind of the target resource.
    //
    // +kubebuilder:validation:MinLength=1
    // +kubebuilder:validation:MaxLength=253
    Kind string `json:"kind"`

    // Name is the name of the target resource.
    //
    // +kubebuilder:validation:MinLength=1
    // +kubebuilder:validation:MaxLength=253
    Name string `json:"name"`

    // Namespace is the namespace of the referent. When unspecified, the local
    // namespace is inferred. Even when policy targets a resource in a different
    // namespace, it may only apply to traffic originating from the same
    // namespace as the policy.
    //
    // +kubebuilder:validation:MinLength=1
    // +kubebuilder:validation:MaxLength=253
    // +optional
    Namespace string `json:"namespace,omitempty"`
}
@maleck13
Copy link
Contributor Author

Initially we may want to skip the Namespace option here as I don't think it is relevant

@eguzki eguzki self-assigned this Mar 25, 2022
@rahulanand16nov
Copy link
Contributor

It's recommended in the doc to use the same structs so, even if Namespace is present, we can ignore its usage in the controller.

@maleck13
Copy link
Contributor Author

👍

@maleck13
Copy link
Contributor Author

Lets target the Gateway API HTTPRoute first

@maleck13 maleck13 added the epic label Mar 28, 2022
@maleck13 maleck13 changed the title Add a target ref to the Rate Limit Policy resource Bring RateLimitPolicy inline with the Gateway API policy attachment concepts Mar 28, 2022
@maleck13 maleck13 changed the title Bring RateLimitPolicy inline with the Gateway API policy attachment concepts RateLimitPolicy add the Gateway API policy attachment concepts Mar 30, 2022
@maleck13 maleck13 removed this from Kuadrant Mar 31, 2022
@maleck13 maleck13 moved this to Todo in Kuadrant Mar 31, 2022
@maleck13 maleck13 removed the status in Kuadrant Mar 31, 2022
@maleck13 maleck13 removed this from Kuadrant Mar 31, 2022
@eguzki eguzki removed their assignment Apr 4, 2022
@eguzki
Copy link
Contributor

eguzki commented Apr 4, 2022

Added Support targeting a TLSRoute with the target ref task to the epic

@maleck13 maleck13 moved this to In Review in Kuadrant Apr 20, 2022
@maleck13 maleck13 moved this from In Review to Todo in Kuadrant Apr 20, 2022
@maleck13 maleck13 removed the status in Kuadrant Apr 20, 2022
@maleck13 maleck13 moved this to In Progress in Kuadrant May 4, 2022
@maleck13 maleck13 added kind/epic and removed epic labels May 5, 2022
@maleck13 maleck13 moved this to In Progress in Kuadrant Service Protection May 5, 2022
@maleck13 maleck13 moved this from In Progress to Ready in Kuadrant Service Protection May 11, 2022
@eguzki eguzki moved this from In Progress to Todo in Kuadrant May 26, 2022
@eguzki eguzki moved this from Todo to In Progress in Kuadrant May 26, 2022
@alexsnaps alexsnaps moved this from Ready to In Progress in Kuadrant Service Protection Jun 15, 2022
@eguzki eguzki moved this from In Progress to Ready in Kuadrant Service Protection Jun 17, 2022
@eguzki eguzki removed their assignment Jun 17, 2022
@maleck13 maleck13 added this to the v0.1.0 milestone Jun 29, 2022
@maleck13 maleck13 moved this from Ready to In Progress in Kuadrant Service Protection Jun 29, 2022
@maleck13 maleck13 changed the title RateLimitPolicy add the Gateway API policy attachment concepts RateLimitPolicy add Gateway API policy attachment concepts Aug 18, 2022
@maleck13 maleck13 changed the title RateLimitPolicy add Gateway API policy attachment concepts RateLimitPolicy add Gateway API policy attachment (target ref) Aug 18, 2022
@eguzki eguzki closed this as completed Nov 3, 2022
Repository owner moved this from In Progress to Done in Kuadrant Service Protection Nov 3, 2022
Repository owner moved this from In Progress to Done in Kuadrant Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/epic target/current Current work sprint
Projects
No open projects
Status: Done
Status: Done
Development

No branches or pull requests

3 participants