You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a developer, I would like two equivalent methods of calculation to have a similar performance in case of piping calculations.
When looking at the sellmeijer test cases, there is a significant difference in performance between the old interface-based piping element and the new line-based element.
For example, when looking at this example, the 'old' version takes ~37s
test_sellmeijers_rule_height_35_7_36 (test_sellmeijers_rule_validation.TestSellmeijersRuleValidation) ... 36.594s ...ok
While the new one takes ~72s
test_sellmeijers_rule_height_line_35_7_36 (test_sellmeijers_rule_validation.TestSellmeijersRuleValidation) ... 72.415s ...ok
I've had a brief look using VTune, and it doesn't seem to be related to the calculation time in the piping element itself (which is negligible compared to the calculation time in the continuum elements), so it might be related to how quickly the calculation converges. Therefore it's different from the performance improvements we did for DGeoFlow
REFINEMENT 03/02/2025
The first step is to look into the logging.
The text was updated successfully, but these errors were encountered:
As a developer, I would like two equivalent methods of calculation to have a similar performance in case of piping calculations.
When looking at the sellmeijer test cases, there is a significant difference in performance between the old interface-based piping element and the new line-based element.
For example, when looking at this example, the 'old' version takes ~37s
test_sellmeijers_rule_height_35_7_36 (test_sellmeijers_rule_validation.TestSellmeijersRuleValidation) ... 36.594s ...ok
While the new one takes ~72s
test_sellmeijers_rule_height_line_35_7_36 (test_sellmeijers_rule_validation.TestSellmeijersRuleValidation) ... 72.415s ...ok
I've had a brief look using VTune, and it doesn't seem to be related to the calculation time in the piping element itself (which is negligible compared to the calculation time in the continuum elements), so it might be related to how quickly the calculation converges. Therefore it's different from the performance improvements we did for DGeoFlow
REFINEMENT 03/02/2025
The first step is to look into the logging.
The text was updated successfully, but these errors were encountered: