Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Investigate performance of 'new' piping element #13092

Open
rfaasse opened this issue Feb 4, 2025 · 0 comments · May be fixed by #13091
Open

[GeoMechanicsApplication] Investigate performance of 'new' piping element #13092

rfaasse opened this issue Feb 4, 2025 · 0 comments · May be fixed by #13091
Assignees
Labels
GeoMechanics Issues related to the GeoMechanicsApplication Performance

Comments

@rfaasse
Copy link
Contributor

rfaasse commented Feb 4, 2025

As a developer, I would like two equivalent methods of calculation to have a similar performance in case of piping calculations.

When looking at the sellmeijer test cases, there is a significant difference in performance between the old interface-based piping element and the new line-based element.

For example, when looking at this example, the 'old' version takes ~37s
test_sellmeijers_rule_height_35_7_36 (test_sellmeijers_rule_validation.TestSellmeijersRuleValidation) ... 36.594s ...ok

While the new one takes ~72s
test_sellmeijers_rule_height_line_35_7_36 (test_sellmeijers_rule_validation.TestSellmeijersRuleValidation) ... 72.415s ...ok

I've had a brief look using VTune, and it doesn't seem to be related to the calculation time in the piping element itself (which is negligible compared to the calculation time in the continuum elements), so it might be related to how quickly the calculation converges. Therefore it's different from the performance improvements we did for DGeoFlow


REFINEMENT 03/02/2025
The first step is to look into the logging.

@rfaasse rfaasse self-assigned this Feb 4, 2025
@rfaasse rfaasse converted this from a draft issue Feb 4, 2025
@rfaasse rfaasse moved this from 📑 Product Backlog to 📋 Sprint Backlog in Kratos Product Backlog Feb 4, 2025
@rfaasse rfaasse moved this from 📋 Sprint Backlog to 👷 In Progress in Kratos Product Backlog Feb 4, 2025
@rfaasse rfaasse added GeoMechanics Issues related to the GeoMechanicsApplication Performance labels Feb 4, 2025
@rfaasse rfaasse moved this from 👷 In Progress to 👀 In Review in Kratos Product Backlog Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GeoMechanics Issues related to the GeoMechanicsApplication Performance
Projects
None yet
1 participant