Skip to content

Commit f63c633

Browse files
committed
including dataframe-csv by default in the dataframe dependency
1 parent b274268 commit f63c633

File tree

4 files changed

+3
-11
lines changed

4 files changed

+3
-11
lines changed

build.gradle.kts

+1-2
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,7 @@ dependencies {
5555
api(project(":dataframe-excel"))
5656
api(project(":dataframe-openapi"))
5757
api(project(":dataframe-jdbc"))
58-
// TODO enable when it leaves the experimental phase
59-
// api(project(":dataframe-csv"))
58+
api(project(":dataframe-csv"))
6059

6160
kover(project(":core"))
6261
kover(project(":dataframe-arrow"))

dataframe-csv/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/CommonReadDelimDocs.kt

-3
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,6 @@ import java.net.URL
4444
*
4545
* $[STR_FUNCTION_LINK]`("a,b,c", delimiter = ",")`
4646
*
47-
* _**NOTE EXPERIMENTAL**: This is a new set of functions, replacing the old $[OLD_FUNCTION_LINK]`()` functions.
48-
* They'll hopefully be faster and better._
49-
*
5047
* @comment Some helper arguments for the function links
5148
* @set [FUNCTION_LINK] \[DataFrame.${[FUNCTION_NAME]}\]\[${[FUNCTION_NAME]}\]
5249
* @set [STR_FUNCTION_LINK] \[DataFrame.${[FUNCTION_NAME]}Str\]\[${[FUNCTION_NAME]}Str\]

dataframe-csv/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/CommonWriteDelimDocs.kt

-4
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@ import java.io.File
3131
*
3232
* $[TO_STR_FUNCTION_LINK]`(delimiter = ",")`
3333
*
34-
* _**NOTE EXPERIMENTAL**: This is a new set of functions, replacing the old
35-
* [DataFrame.writeCSV][writeCSV]`()` and [DataFrame.toCsv][toCsv]`()` functions.
36-
* They'll hopefully be better._
37-
*
3834
* @comment Some helper arguments for the function links
3935
* @set [FUNCTION_LINK] \[DataFrame.${[FUNCTION_NAME]}\]\[${[FUNCTION_NAME]}\]
4036
* @set [TO_STR_FUNCTION_LINK] \[DataFrame.${[TO_STR_FUNCTION_NAME]}\]\[${[TO_STR_FUNCTION_NAME]}\]

dataframe-csv/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/csv.kt

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ public class CsvDeephaven(private val delimiter: Char = DelimParams.CSV_DELIMITE
2121

2222
override fun acceptsSample(sample: SupportedFormatSample): Boolean = true // Extension is enough
2323

24-
// if the user adds the dataframe-csv module, this will override old CSV reading method in DataFrame.read()
25-
override val testOrder: Int = CSV().testOrder - 1
24+
// this will override old CSV reading method in DataFrame.read()
25+
override val testOrder: Int = 19_999
2626

2727
override fun createDefaultReadMethod(pathRepresentation: String?): DefaultReadDfMethod {
2828
val arguments = MethodArguments().add("delimiter", typeOf<Char>(), "'%L'", delimiter)

0 commit comments

Comments
 (0)