fixed tests csv, fixed gradle plugin delimiter for csv

Author: Jolanrensen

core/build.gradle.kts

@@ -86,8 +86,8 @@ dependencies {
     testImplementation(libs.jsoup)
     testImplementation(libs.sl4jsimple)
 
-    // for JupyterCodegenTests only
-    testRuntimeOnly(project(":dataframe-csv"))
+    // for JupyterCodegenTests and samples.api
+    testImplementation(project(":dataframe-csv"))
 }
 
 val samplesImplementation by configurations.getting {

core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Schemas.kt

@@ -127,8 +127,8 @@ class Schemas {
     @TransformDataFrameExpressions
     fun useInferredSchema() {
         // SampleStart
-        // Repository.readCSV() has argument 'path' with default value https://raw.githubusercontent.com/Kotlin/dataframe/master/data/jetbrains_repositories.csv
-        val df = Repository.readCSV()
+        // Repository.readCsv() has argument 'path' with default value https://raw.githubusercontent.com/Kotlin/dataframe/master/data/jetbrains_repositories.csv
+        val df = Repository.readCsv()
         // Use generated properties to access data in rows
         df.maxBy { stargazersCount }.print()
         // Or to access columns in dataframe.

dataframe-csv/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/csv.kt

@@ -12,10 +12,10 @@ import kotlin.reflect.typeOf
 
 public class CsvDeephaven(private val delimiter: Char = DelimParams.CSV_DELIMITER) : SupportedDataFrameFormat {
     override fun readDataFrame(stream: InputStream, header: List<String>): DataFrame<*> =
-        DataFrame.readCsv(inputStream = stream, header = header)
+        DataFrame.readCsv(inputStream = stream, header = header, delimiter = delimiter)
 
     override fun readDataFrame(file: File, header: List<String>): DataFrame<*> =
-        DataFrame.readCsv(file = file, header = header)
+        DataFrame.readCsv(file = file, header = header, delimiter = delimiter)
 
     override fun acceptsExtension(ext: String): Boolean = ext == "csv"
 

dataframe-csv/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/tsv.kt

@@ -12,10 +12,10 @@ import kotlin.reflect.typeOf
 
 public class TsvDeephaven(private val delimiter: Char = DelimParams.TSV_DELIMITER) : SupportedDataFrameFormat {
     override fun readDataFrame(stream: InputStream, header: List<String>): DataFrame<*> =
-        DataFrame.readTsv(inputStream = stream, header = header)
+        DataFrame.readTsv(inputStream = stream, header = header, delimiter = delimiter)
 
     override fun readDataFrame(file: File, header: List<String>): DataFrame<*> =
-        DataFrame.readTsv(file = file, header = header)
+        DataFrame.readTsv(file = file, header = header, delimiter = delimiter)
 
     override fun acceptsExtension(ext: String): Boolean = ext == "tsv"
 

plugins/dataframe-gradle-plugin/src/test/kotlin/org/jetbrains/dataframe/gradle/DataFrameReadTest.kt

@@ -9,6 +9,7 @@ import kotlinx.serialization.SerializationException
 import org.jetbrains.kotlinx.dataframe.DataFrame
 import org.jetbrains.kotlinx.dataframe.api.isEmpty
 import org.jetbrains.kotlinx.dataframe.io.read
+import org.jetbrains.kotlinx.dataframe.io.readCsv
 import org.jetbrains.kotlinx.dataframe.io.readSqlTable
 import org.junit.Test
 import java.io.File
@@ -82,7 +83,7 @@ class DataFrameReadTest {
     @Test
     fun `data accessible and readable`() {
         shouldNotThrowAny {
-            DataFrame.read(Paths.get("../../data/jetbrains repositories.csv").absolutePathString())
+            DataFrame.readCsv(Paths.get("../../data/jetbrains repositories.csv").absolutePathString(), skipLines = 1)
         }
     }