S3M requires 6 bytes after last pattern before end of file

[sfiera]

The S3M file loader requires patterns to end at least 6 bytes before the end of the file:

libmodplug/src/load_s3m.cpp

Line 347 in d1b97ed

if ((!len) || (nInd + len > dwMemLength - 6)

I have some S3M files that lack this padding. They seem to play fine in MilkyTracker, but libmodplug drops the final pattern due to the lack of padding. I cannot find any documentation for why it should be necessary to include.

Is it necessary? Can the - 6 not be simply removed?

[Konstanty]

Probably a check could be made to check that len is at least 6 (the size of a MODCOMMAND), in the lines preceding instead. Will look into it.