Stop guarding on KCL errors: let people point-and-click a fix (#8721)

Author: pierremtb

src/Toolbar.tsx

@@ -170,8 +170,7 @@ export function Toolbar({
       const isDisabled =
         disableAllButtons ||
         !isConfiguredAvailable ||
-        maybeIconConfig.disabled?.(state) === true ||
-        kclManager.hasErrors()
+        maybeIconConfig.disabled?.(state) === true
 
       // Calculate the isActive state for this specific item
       const itemIsActive = maybeIconConfig.isActive?.(state) || false
@@ -495,15 +494,6 @@ const ToolbarItemTooltip = memo(function ToolbarItemContents({
       contentClassName={contentClassName}
     >
       {children}
-      {kclManager.hasErrors() && (
-        <p className="text-xs p-1 text-chalkboard-70 dark:text-chalkboard-40">
-          <CustomIcon
-            name="exclamationMark"
-            className="w-4 h-4 inline-block mr-1 text-destroy-80 bg-destroy-10"
-          />
-          Fix KCL errors to enable tools
-        </p>
-      )}
     </Tooltip>
   )
 })

src/components/layout/areas/FeatureTreePane.tsx

@@ -395,10 +395,10 @@ const OperationItemWrapper = ({
             </code>
           )}
         </div>
+        {errors && errors.length > 0 && (
+          <em className="text-destroy-80 text-xs">has error</em>
+        )}
       </button>
-      {errors && errors.length > 0 && (
-        <em className="text-destroy-80 text-xs">has error</em>
-      )}
       {visibilityToggle && <VisibilityToggle {...visibilityToggle} />}
       {menuItems && (
         <ContextMenu menuTargetElement={menuRef} items={menuItems} />

src/lang/langHelpers.ts

@@ -137,7 +137,10 @@ function handleExecuteError(e: any): ExecutionResult {
       isInterrupted = true
     }
     const execState = emptyExecState()
+    // We're passing back those so the user can still fix issues in p&c
     execState.variables = e.variables
+    execState.operations = e.operations
+    execState.artifactGraph = e.artifactGraph
     return {
       errors: [e],
       logs: [],

src/machines/modelingMachine.ts

@@ -409,14 +409,11 @@ export const modelingMachine = setup({
     },
     'Has exportable geometry': () => false,
     'has valid selection for deletion': () => false,
+    // TODO: figure out if we really need this one, was separate from 'no kcl errors'
     'is-error-free': ({ context }): boolean => {
       const theKclManager = context.kclManager ? context.kclManager : kclManager
       return theKclManager.errors.length === 0 && !theKclManager.hasErrors()
     },
-    'no kcl errors': ({ context }) => {
-      const theKclManager = context.kclManager ? context.kclManager : kclManager
-      return !theKclManager.hasErrors()
-    },
     'is editing existing sketch': ({
       context: { sketchDetails, kclManager: providedKclManager },
     }) => {
@@ -4220,150 +4217,120 @@ export const modelingMachine = setup({
                 sceneInfra.animate()
               },
             ],
-            guard: 'no kcl errors',
           },
         ],
 
+        // Modeling codemods
+
         Extrude: {
           target: 'Applying extrude',
-          reenter: true,
-          guard: 'no kcl errors',
         },
 
         Sweep: {
           target: 'Applying sweep',
-          reenter: true,
-          guard: 'no kcl errors',
         },
 
         Loft: {
           target: 'Applying loft',
-          reenter: true,
-          guard: 'no kcl errors',
         },
 
         Revolve: {
           target: 'Applying revolve',
-          reenter: true,
-          guard: 'no kcl errors',
         },
 
         'Offset plane': {
           target: 'Applying offset plane',
-          reenter: true,
-          guard: 'no kcl errors',
         },
 
         Helix: {
           target: 'Applying helix',
-          reenter: true,
-          guard: 'no kcl errors',
         },
 
         Shell: {
           target: 'Applying shell',
-          reenter: true,
-          guard: 'no kcl errors',
         },
 
         Hole: {
           target: 'Applying hole',
-          reenter: true,
-          guard: 'no kcl errors',
         },
 
         Fillet: {
           target: 'Applying fillet',
-          reenter: true,
-          guard: 'no kcl errors',
         },
 
         Chamfer: {
           target: 'Applying chamfer',
-          reenter: true,
-          guard: 'no kcl errors',
-        },
-
-        Export: {
-          target: 'Exporting',
-          guard: 'Has exportable geometry',
         },
 
-        Make: {
-          target: 'Making',
-          guard: 'Has exportable geometry',
-        },
-
-        'Delete selection': {
-          target: 'Applying Delete selection',
-          guard: 'has valid selection for deletion',
-          reenter: true,
-        },
-
-        'Text-to-CAD': {
-          target: 'idle',
-          reenter: false,
-          actions: ['Submit to Text-to-CAD API'],
-        },
-
-        'Prompt-to-edit': 'Applying Prompt-to-edit',
-
         Appearance: {
           target: 'Applying appearance',
-          reenter: true,
-          guard: 'no kcl errors',
         },
 
         Translate: {
           target: 'Applying translate',
-          reenter: true,
-          guard: 'no kcl errors',
         },
 
         Rotate: {
           target: 'Applying rotate',
-          reenter: true,
-          guard: 'no kcl errors',
         },
 
         Scale: {
           target: 'Applying scale',
-          reenter: true,
-          guard: 'no kcl errors',
         },
 
         Clone: {
           target: 'Applying clone',
-          reenter: true,
-          guard: 'no kcl errors',
         },
 
         'GDT Flatness': {
           target: 'Applying GDT Flatness',
-          reenter: true,
-          guard: 'no kcl errors',
         },
 
         'Boolean Subtract': {
           target: 'Boolean subtracting',
-          guard: 'no kcl errors',
         },
+
         'Boolean Union': {
           target: 'Boolean uniting',
-          guard: 'no kcl errors',
         },
+
         'Boolean Intersect': {
           target: 'Boolean intersecting',
-          guard: 'no kcl errors',
         },
+
         'Pattern Circular 3D': {
           target: 'Pattern Circular 3D',
-          guard: 'no kcl errors',
         },
+
         'Pattern Linear 3D': {
           target: 'Pattern Linear 3D',
-          guard: 'no kcl errors',
         },
+
+        // Modeling actions
+
+        Export: {
+          target: 'Exporting',
+          guard: 'Has exportable geometry',
+        },
+
+        Make: {
+          target: 'Making',
+          guard: 'Has exportable geometry',
+        },
+
+        'Delete selection': {
+          target: 'Applying Delete selection',
+          guard: 'has valid selection for deletion',
+          reenter: true,
+        },
+
+        'Text-to-CAD': {
+          target: 'idle',
+          reenter: false,
+          actions: ['Submit to Text-to-CAD API'],
+        },
+
+        'Prompt-to-edit': 'Applying Prompt-to-edit',
       },
 
       entry: 'reset client scene mouse handlers',
@@ -4373,7 +4340,6 @@ export const modelingMachine = setup({
           on: {
             'Artifact graph emptied': {
               target: 'showPlanes',
-              guard: 'no kcl errors',
             },
           },