Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Manage Folders/Shared Folders #10

Open
CSimpiFoN opened this issue Nov 4, 2022 · 12 comments
Open

Feature Request - Manage Folders/Shared Folders #10

CSimpiFoN opened this issue Nov 4, 2022 · 12 comments

Comments

@CSimpiFoN
Copy link

Please add the functionality to manage folders and shared folders with Terraform (Creating/Deleting/Sharing)

Or at least add 'folder' data source, so the UID won't need to be checked and added manually to every single secret.

@ladams-keeper
Copy link

Hello,
Could you please describe what you are hoping to achieve with the Terraform Secrets Manager integration in this case?

When you say "add 'folder' data source, so the UID won't need to be checked and added manually to every single secret." Do you mean the folder UID which is required when creating new secrets, or something else?

@heretic098
Copy link

Again, while I'm here. At the moment my workflow to use the keeper terraform provider goes like this:

  1. Create a shared folder in the main Keeper web vault screen
  2. Use the ksm cli to get the shared folder's uid
  3. Hard code that uid into a variable in terraform
  4. Create secretsmanager resources using that shared folder uid which I get from my terraform variable

What I would rather do is:

  1. Use the new keeper secretsmanager_shared_folder resource to create my shared folder
  2. Pass the shared folder uid to other keeper secretsmanager* resources using a terraform output, e.g. below

folder_uid = secretsmanager_shared_folder.my_folder.uid

Or at the very least, have a data_source that lets me pick up the folder UID based on the name of the folder so that I can pass that to other secretsmanager resources. I'm assuming my problem is representative of what @CSimpiFoN is asking.

@ppodevlabs
Copy link

this would be really helpful for us to manage shared folders within teams, etc

@maksimu
Copy link
Collaborator

maksimu commented Mar 30, 2023

Filed internally as KSM-390

@rdavisunr
Copy link

Filed internally as KSM-390

@maksimu - what was the outcome of this internal issue?

My company is a Keeper customer and we are currently evaluating Secrets Manager as a potential addition.

In the prototype I am developing, it would be very useful to have a data source that could return a Shared Folder UID based on a Folder Name.

I'd also vote for Shared Folder creation/management, but I assume there are complexities due to the relationship between Shared Folders and Applications (like Terraform itself).

@ericrichtert
Copy link

Any update on this?

@ghost
Copy link

ghost commented Dec 11, 2023

We need this feature as well, please
Without managing folders, the keeper provider is not feature complete (i.e. we cannot create a full tree of folders/secrets using terraform). We'd have to do some things manually, and some automated with terraform, which is less than ideal..

@ilsaloving
Copy link

This issue isn't even specific to terraform. It looks like none of the integrations have the ability to enumerate shared folders. How did it not occur to anyone that such functionality would be critical?

@ghost
Copy link

ghost commented Apr 25, 2024

Hi, is there an update on this, please?

@craiglurey
Copy link

craiglurey commented Apr 26, 2024 via email

@starcraft66
Copy link

Hi, was wondering if this feature will land soon as you mentioned it was in development approx. 9 months ago. We are in the process of procuring KSM and having this feature would greatly simplify the amount of integration work required.

@idimov-keeper
Copy link
Contributor

This feature will be included in the release-v1.1.5 which will come out early next week (ETA: Monday)
Note: Currently Keeper does not support shared folders within shared folders so you can only manage regular folders within a KSM Application (since parent folder shared to the KSM App must be a shared folder) This affects only folder creation in a resource - all folders are accessible through a data_source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests