add support for 1) config settings "unmask_all" and "fail_on_throttle" and 2) corresponding "--unmask-all" and "--fail-on-throttle" CLI flags

Author: aaunario-keeper

keepercommander/__main__.py

@@ -112,6 +112,10 @@ def get_shortcut_config():
                         if isinstance(on_throttle, bool):
                             params.rest_context._fail_on_throttle = on_throttle
 
+                    unmask_all = params.config.get('unmask_all')
+                    if isinstance(unmask_all, bool):
+                        params.unmask_all = unmask_all
+
             except Exception as e:
                 logging.error('Unable to parse JSON configuration file "%s"', params.config_filename)
                 answer = input('Do you want to delete it (y/N): ')
@@ -147,6 +151,11 @@ def usage(m):
                     help='Indicates that the app was launched using a shortcut, for example using Mac App or from '
                          'Windows Start Menu.')
 parser.add_argument('--proxy', dest='proxy', action='store', help='Proxy server..')
+unmask_help = 'Disable default masking of sensitive information (e.g., passwords) in output'
+parser.add_argument('--unmask-all', action='store_true', help=unmask_help)
+fail_on_throttle_help = 'Disable default client-side pausing of command execution and re-sending of requests upon ' \
+                        'server-side throttling'
+parser.add_argument('--fail-on-throttle', action='store_true', help=fail_on_throttle_help)
 parser.add_argument('command', nargs='?', type=str, action='store', help='Command')
 parser.add_argument('options', nargs='*', action='store', help='Options')
 parser.error = usage
@@ -190,6 +199,12 @@ def main(from_package=False):
     if opts.user:
         params.user = opts.user
 
+    if opts.unmask_all:
+        params.unmask_all = opts.unmask_all
+
+    if opts.fail_on_throttle:
+        params.rest_context._fail_on_throttle = opts.fail_on_throttle
+
     if opts.password:
         params.password = opts.password
     else:

keepercommander/commands/record.py

@@ -339,10 +339,11 @@ def execute(self, params, **kwargs):
                 elif fmt == 'password':
                     print(r.password)
                 else:
+                    unmask = params.unmask_all or kwargs.get('unmask')
                     if version < 3:
-                        r.display(unmask=kwargs.get('unmask', False))
+                        r.display(unmask=unmask)
                     else:
-                        recordv3.RecordV3.display(rec, **{'params': params, 'format': fmt, 'unmask': kwargs.get('unmask')})
+                        recordv3.RecordV3.display(rec, **{'params': params, 'format': fmt, 'unmask': unmask})
 
                     folders = [get_folder_path(params, x) for x in find_folders(params, uid)]
                     for i in range(len(folders)):

keepercommander/params.py

@@ -160,6 +160,7 @@ def __init__(self, config_filename='', config=None, server='keepersecurity.com',
         self.sso_login_info = None
         self.__proxy = None
         self.ssh_agent = None
+        self.unmask_all = False
 
     def clear_session(self):
         self.auth_verifier = None
@@ -215,6 +216,7 @@ def clear_session(self):
         self.breach_watch = None
         self.breach_watch_records = None
         self.sso_login_info = None
+        self.unmask_all = False
         if self.ssh_agent:
             self.ssh_agent.close()
             self.ssh_agent = None