Merge pull request #3 from KaririCode-Framework/develop

refactor(logging): encapsulate conditional logic into methods for bet…

Author: walmir-silva

src/Handler/AbstractFileHandler.php

@@ -24,15 +24,21 @@ public function __construct(
     protected function ensureDirectoryExists(): void
     {
         $directory = dirname($this->filePath);
-        if (!is_dir($directory)) {
-            if (!$this->createDirectory($directory)) {
-                throw new LoggingException("Unable to create log directory: $directory");
-            }
-        } elseif (!$this->isDirectoryWritable($directory)) {
+
+        if ($this->directoryDoesNotExist($directory) && !$this->createDirectory($directory)) {
+            throw new LoggingException("Unable to create log directory: $directory");
+        }
+
+        if (!$this->isDirectoryWritable($directory)) {
             throw new LoggingException("Log directory is not writable: $directory");
         }
     }
 
+    private function directoryDoesNotExist(string $directory): bool
+    {
+        return !is_dir($directory);
+    }
+
     protected function createDirectory($path)
     {
         return mkdir($path, 0777, true);

src/LoggerManager.php

@@ -51,14 +51,19 @@ public function log(LogLevel $level, string|\Stringable $message, array $context
     private function passesThreshold(array $context): bool
     {
         foreach ($this->thresholds as $key => $threshold) {
-            if (isset($context[$key]) && $context[$key] < $threshold) {
+            if ($this->contextBelowThreshold($context, $key, $threshold)) {
                 return false;
             }
         }
 
         return true;
     }
 
+    private function contextBelowThreshold(array $context, string $key, int $threshold): bool
+    {
+        return isset($context[$key]) && $context[$key] < $threshold;
+    }
+
     public function addHandler(HandlerAware $handler): self
     {
         $this->handlers[] = $handler;

src/Util/ReflectionFactoryTrait.php

@@ -103,13 +103,18 @@ private function filterConstructorParameters(\ReflectionClass $reflectionClass,
      */
     protected function getClassFromMap(array $map, string $key): string
     {
-        if (!isset($map[$key])) {
+        if ($this->configurationNotFound($map, $key)) {
             throw new InvalidConfigurationException("Configuration not found for key: $key");
         }
 
         return self::validateAndExtractClass($map[$key], $key);
     }
 
+    private function configurationNotFound(array $map, string $key): bool
+    {
+        return !isset($map[$key]);
+    }
+
     /**
      * Validates and extracts the class from a configuration value.
      *

src/Util/SlackClient.php

@@ -75,7 +75,7 @@ private function sendRequest(array $payload): array
         ];
 
         try {
-            return $this->curlClient->post(self::SLACK_API_URL, $payload, $headers);
+            return $this->postToSlack($payload, $headers);
         } catch (\JsonException $e) {
             $this->circuitBreaker->recordFailure();
             throw new LoggingException('Failed to encode message for Slack: ' . $e->getMessage(), 0, $e);
@@ -85,6 +85,11 @@ private function sendRequest(array $payload): array
         }
     }
 
+    private function postToSlack(array $payload, array $headers): array
+    {
+        return $this->curlClient->post(self::SLACK_API_URL, $payload, $headers);
+    }
+
     private function handleResponse(array $response): void
     {
         $httpCode = $response['status'];