Using interactive() was not a good idea

It confused me a lot that all tests passed but
going through a test manually failed!

Author: hsonne

R/getObservationRecordsFromEuLines.R

@@ -12,14 +12,17 @@ getObservationRecordsFromEuLines <- function(
     silent = TRUE
   )
 
+  dot.args <- list(...)
+  #dot.args <- list() # for debugging!
+  
   if (kwb.utils::isTryError(observations)) {
     observations <- kwb.utils::callWith(
       extractObservationData,
       euLines = eu_lines, 
       headerInfo = getHeaderInfo(eu_lines), 
       header.info = header.info,
       file = file,
-      if (interactive()) list() else list(...)
+      dot.args
     )
   }
 

R/getObservationsFromEuLines.R

@@ -154,6 +154,9 @@ readObservationsFromCsvText <- function(text, sep, dec, quote, colClasses, ...)
     colClasses <- colClasses[colNames]
   }
 
+  dot.args <- list(...)
+  #dot.args <- list() # for debugging!
+  
   kwb.utils::callWith(
     utils::read.table,
     text = text, 
@@ -164,7 +167,7 @@ readObservationsFromCsvText <- function(text, sep, dec, quote, colClasses, ...)
     blank.lines.skip = FALSE, 
     stringsAsFactors = FALSE, 
     colClasses = colClasses,
-    if (interactive()) list() else list(...)
+    dot.args
   )
 }
 

R/readAndMergeEuCodedFiles.R

@@ -31,6 +31,9 @@ readAndMergeEuCodedFiles <- function(
   error.file = NULL
 )
 {
+  dot.args <- list(...)
+  #dot.args <- list() # for debugging!
+  
   # by setting simple.algorithm = FALSE we get unique column names, e.g. "ADE"
   # and "ADE.1"
   inspection.data.list <- kwb.utils::callWith(
@@ -39,7 +42,7 @@ readAndMergeEuCodedFiles <- function(
     dbg = dbg, 
     name.convention = name.convention,
     simple.algorithm = FALSE, 
-    if (interactive()) list() else list(...)
+    dot.args
   )
 
   result <- mergeInspectionData(inspection.data.list)

R/readEuCodedFile.R

@@ -102,6 +102,9 @@ readEuCodedFile <- function(
     )
   )
 
+  dot.args <- list(...)
+  #dot.args <- list() # for debugging!
+  
   observations <- run(
     "Extracting observation records",
     kwb.utils::callWith(
@@ -110,7 +113,7 @@ readEuCodedFile <- function(
       header.info = header.info, 
       dbg = dbg,
       file = input.file,
-      if (interactive()) list() else list(...)
+      dot.args
     )
   )
 

R/readEuCodedFiles.R

@@ -33,11 +33,14 @@ readEuCodedFiles <- function(
       "input file %d/%d: %s\n", i, length(input.files), input.file
     ))
 
+    dot.args <- list(...)
+    #dot.args <- list() # for debugging!
+    
     inspectionData <- try(silent = TRUE, kwb.utils::callWith(
       readEuCodedFile,
       input.file = input.file, 
       dbg = dbg, 
-      if (interactive()) list() else list(...)
+      dot.args
     ))
 
     # Return the error object if an error occurred