Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotspot should escape Caller/Callee data to be graphed #691

Open
cmack opened this issue Jan 25, 2025 · 0 comments
Open

Hotspot should escape Caller/Callee data to be graphed #691

cmack opened this issue Jan 25, 2025 · 0 comments
Labels

Comments

@cmack
Copy link

cmack commented Jan 25, 2025

Describe the bug
While inspecting perf output from a dynamic language (Common Lisp; SBCL implementation) the Callee/Caller tab will not show the call graph for certain items when clicked.

I used graphviz's dot command to check the tmp file and found it also could not parse some items because the double-quotes were not escaped. I believe this is the main problem preventing display.

To Reproduce
Steps to reproduce the behavior:

  1. Use SBCL and its sb-perf package to create the debug symbols then start perf recording normally. (I don't expect hotpot devs to do this unless they really want to)
  2. Start Hotspot and then click on the Callee/Caller tab
  3. Click on Callee or Caller items until you have a screen like the screenshot provided where the graph /tmp/hotspot.<blah> loading... message is seen and doesn't change even given enough time.

Expected behavior
For hotspot to generate a proper digraph file in the presence of symbols that have double quotes (or anything else that should be escaped) and the expected call graph can be seen.

Screenshots

Image

Version Info (please complete the following information):

  • Linux Kernel version: Linux multivec 6.12.10 #1 SMP PREEMPT_DYNAMIC 1 x86_64 GNU/Linux
  • perf version: perf version 6.12.10-gnu
  • hotspot version (appimage? selfcompiled?): 1.5.80 -- GUIX compiled
  • if self-compiled hotspot, what version of elfutils:

Additional context
This is the generated tmp file.

hotspot.GSyuJj.txt

@cmack cmack added the bug label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant