cmake: set MSVC_RUNTIME_LIBRARY to MultiThreadedDLL

As Rust always uses the non-debug Windows runtime for MSVC targets.

Related to #682
Related to #676

Author: ahayzen-kdab

CHANGELOG.md

@@ -48,6 +48,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Do not use -bundle otherwise CMake builds are missing qt-static-initalizers (note this is broken in rustc 1.69)
 - Do not import `Pin` in hidden module as invokables are outside now, resolving IDE integration
+- Rust always links against a non-debug Windows runtime with *-msvc targets, so we need to link to MultiThreadedDLL
 
 ### Removed
 

examples/demo_threading/CMakeLists.txt

@@ -8,6 +8,14 @@ cmake_minimum_required(VERSION 3.24)
 project(demo_threading)
 set(APP_NAME ${PROJECT_NAME})
 
+# Rust always links against non-debug Windows runtime on *-msvc targets
+# Note it is best to set this on the command line to ensure all targets are consistent
+# https://github.com/corrosion-rs/corrosion/blob/master/doc/src/common_issues.md#linking-debug-cc-libraries-into-rust-fails-on-windows-msvc-targets
+# https://github.com/rust-lang/rust/issues/39016
+if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+  set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreadedDLL")
+endif()
+
 set(CMAKE_AUTOMOC ON)
 set(CMAKE_AUTORCC ON)
 set(CMAKE_CXX_STANDARD 17)

examples/qml_features/CMakeLists.txt

@@ -9,6 +9,14 @@ cmake_minimum_required(VERSION 3.24)
 project(example_qml_features)
 set(APP_NAME ${PROJECT_NAME})
 
+# Rust always links against non-debug Windows runtime on *-msvc targets
+# Note it is best to set this on the command line to ensure all targets are consistent
+# https://github.com/corrosion-rs/corrosion/blob/master/doc/src/common_issues.md#linking-debug-cc-libraries-into-rust-fails-on-windows-msvc-targets
+# https://github.com/rust-lang/rust/issues/39016
+if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+  set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreadedDLL")
+endif()
+
 set(CMAKE_AUTOMOC ON)
 set(CMAKE_AUTORCC ON)
 set(CMAKE_CXX_STANDARD 17)

examples/qml_minimal/CMakeLists.txt

@@ -10,6 +10,14 @@ cmake_minimum_required(VERSION 3.24)
 project(example_qml_minimal)
 set(APP_NAME ${PROJECT_NAME})
 
+# Rust always links against non-debug Windows runtime on *-msvc targets
+# Note it is best to set this on the command line to ensure all targets are consistent
+# https://github.com/corrosion-rs/corrosion/blob/master/doc/src/common_issues.md#linking-debug-cc-libraries-into-rust-fails-on-windows-msvc-targets
+# https://github.com/rust-lang/rust/issues/39016
+if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+  set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreadedDLL")
+endif()
+
 set(CMAKE_AUTOMOC ON)
 set(CMAKE_AUTORCC ON)
 set(CMAKE_CXX_STANDARD 17)

tests/basic_cxx_only/CMakeLists.txt

@@ -9,6 +9,14 @@ cmake_minimum_required(VERSION 3.24)
 project(tests_basic_cxx_only)
 set(APP_NAME ${PROJECT_NAME})
 
+# Rust always links against non-debug Windows runtime on *-msvc targets
+# Note it is best to set this on the command line to ensure all targets are consistent
+# https://github.com/corrosion-rs/corrosion/blob/master/doc/src/common_issues.md#linking-debug-cc-libraries-into-rust-fails-on-windows-msvc-targets
+# https://github.com/rust-lang/rust/issues/39016
+if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+  set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreadedDLL")
+endif()
+
 # TODO: Add a helper function to our CMake module which automatically
 # handles some of this boilerplate for a "typical" Qt application
 set(CMAKE_AUTOMOC ON)

tests/basic_cxx_qt/CMakeLists.txt

@@ -9,6 +9,14 @@ cmake_minimum_required(VERSION 3.24)
 project(tests_basic_cxx_qt)
 set(APP_NAME ${PROJECT_NAME})
 
+# Rust always links against non-debug Windows runtime on *-msvc targets
+# Note it is best to set this on the command line to ensure all targets are consistent
+# https://github.com/corrosion-rs/corrosion/blob/master/doc/src/common_issues.md#linking-debug-cc-libraries-into-rust-fails-on-windows-msvc-targets
+# https://github.com/rust-lang/rust/issues/39016
+if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+  set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreadedDLL")
+endif()
+
 # TODO: Add a helper function to our CMake module which automatically
 # handles some of this boilerplate for a "typical" Qt application
 set(CMAKE_AUTOMOC ON)

tests/qt_types_standalone/CMakeLists.txt

@@ -9,6 +9,14 @@ cmake_minimum_required(VERSION 3.24)
 project(tests_qt_types_standalone)
 set(APP_NAME ${PROJECT_NAME})
 
+# Rust always links against non-debug Windows runtime on *-msvc targets
+# Note it is best to set this on the command line to ensure all targets are consistent
+# https://github.com/corrosion-rs/corrosion/blob/master/doc/src/common_issues.md#linking-debug-cc-libraries-into-rust-fails-on-windows-msvc-targets
+# https://github.com/rust-lang/rust/issues/39016
+if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+  set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreadedDLL")
+endif()
+
 # TODO: Add a helper function to our CMake module which automatically
 # handles some of this boilerplate for a "typical" Qt application
 set(CMAKE_AUTOMOC ON)