Make cppcheck happy

Author: seanharmer

src/KDFoundation/object.h

@@ -95,7 +95,7 @@ class KDFOUNDATION_API Object : public EventReceiver
     void deleteLater();
 
     void setObjectName(const std::string &objectName) { m_objectName = objectName; }
-    std::string objectName() const { return m_objectName; }
+    const std::string &objectName() const { return m_objectName; }
 
     void event(EventReceiver *target, Event *ev) override;
 

src/KDUtils/url.cpp

@@ -42,22 +42,22 @@ std::string Url::toLocalFile() const
     return m_path + m_fileName;
 }
 
-std::string Url::scheme() const
+const std::string &Url::scheme() const
 {
     return m_scheme;
 }
 
-std::string Url::fileName() const
+const std::string &Url::fileName() const
 {
     return m_fileName;
 }
 
-std::string Url::path() const
+const std::string &Url::path() const
 {
     return m_path;
 }
 
-std::string Url::url() const
+const std::string &Url::url() const
 {
     return m_url;
 }

src/KDUtils/url.h

@@ -25,10 +25,10 @@ class KDUTILS_API Url
 
     bool isLocalFile() const;
     std::string toLocalFile() const;
-    std::string scheme() const;
-    std::string fileName() const;
-    std::string path() const;
-    std::string url() const;
+    const std::string &scheme() const;
+    const std::string &fileName() const;
+    const std::string &path() const;
+    const std::string &url() const;
     bool empty() const { return m_url.empty(); }
     bool isEmpty() const { return empty(); }