Merge pull request #69 from timholy/teh/inferrability

Add a few precompiles

Author: oxinabox

.github/workflows/UnitTest.yml

@@ -14,6 +14,7 @@ jobs:
   test:
     runs-on: ${{ matrix.os }}
     strategy:
+      fail-fast: false
       matrix:
         julia-version: ['1.0', '1', 'nightly']
         os: [ubuntu-latest, windows-latest, macOS-latest]
@@ -30,7 +31,7 @@ jobs:
         env:
           cache-name: cache-artifacts
         with:
-          path: ~/.julia/artifacts 
+          path: ~/.julia/artifacts
           key: ${{ runner.os }}-test-${{ env.cache-name }}-${{ hashFiles('**/Project.toml') }}
           restore-keys: |
             ${{ runner.os }}-test-${{ env.cache-name }}-

Project.toml

@@ -1,7 +1,7 @@
 name = "ReferenceTests"
 uuid = "324d217c-45ce-50fc-942e-d289b448e8cf"
 authors = ["Christof Stocker <[email protected]>", "Lyndon White <[email protected]>", "Johnny Chen <[email protected]>"]
-version = "0.9.2"
+version = "0.9.3"
 
 [deps]
 DeepDiffs = "ab62b9b5-e342-54a8-a765-a90f495de1a6"
@@ -14,11 +14,16 @@ SHA = "ea8e919c-243c-51af-8825-aaa63cd721ce"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [compat]
+CSVFiles = "1"
+DataFrames = "0.21, 0.22"
 DeepDiffs = "1.1"
 Distances = "0.7, 0.8, 0.9, 0.10"
 FileIO = "1"
 ImageCore = "0.8.1"
 ImageInTerminal = "0.3, 0.4"
+ImageMagick = "0.7, 1"
+ImageTransformations = "0.8"
+TestImages = "0.6, 1"
 julia = "1"
 
 [extras]

src/ReferenceTests.jl

@@ -21,4 +21,11 @@ include("fileio.jl")
 include("equality_metrics.jl")
 include("render.jl")
 
+if Base.VERSION >= v"1.4.2" && ccall(:jl_generating_output, Cint, ()) == 1
+    @assert precompile(Tuple{Core.kwftype(typeof(test_reference)),NamedTuple{(:by,), Tuple{typeof(isequal)}},typeof(test_reference),String,Matrix{RGB{Float64}}})   # time: 0.4697069
+    @assert precompile(Tuple{Core.kwftype(typeof(test_reference)),NamedTuple{(:by,), Tuple{typeof(isequal)}},typeof(test_reference),String,Matrix{RGBA{Float64}}})   # time: 0.24671553
+    @assert precompile(Tuple{typeof(test_reference),File{DataFormat{:PNG}},Matrix{RGB{Float64}},Function,Nothing})   # time: 0.029915236
+    @assert precompile(Tuple{typeof(test_reference),File{DataFormat{:PNG}},Matrix{RGBA{Float64}},Function,Nothing})   # time: 0.013356352
+end
+
 end # module

src/fileio.jl

@@ -4,11 +4,11 @@
 
 const TextFile = Union{File{format"TXT"}, File{format"SHA256"}}
 
-function loadfile(T, file::File)
-    T(load(file)) # Fallback to FileIO
+function loadfile(::Type{T}, file::File) where T
+    T(load(file))::T # Fallback to FileIO
 end
 
-function loadfile(T, file::TextFile)
+function loadfile(::Type{T}, file::TextFile) where T  # specialize on T only to prevent ambiguity
     replace(read(file.filename, String), "\r"=>"") # ignore CRLF/LF difference
 end