Merge pull request #17 from JuliaSIMD/julia1.8

Julia 1.8

Author: chriselrod

Project.toml

@@ -1,7 +1,7 @@
 name = "TriangularSolve"
 uuid = "d5829a12-d9aa-46ab-831f-fb7c9ab06edf"
 authors = ["chriselrod <[email protected]> and contributors"]
-version = "0.1.9"
+version = "0.1.10"
 
 [deps]
 CloseOpenIntervals = "fb6a15b2-703c-40df-9091-08a04967cfa9"

README.md

@@ -70,7 +70,7 @@ BenchmarkTools.Trial: 10000 samples with 1 evaluation.
 ```
 Multithreaded benchmarks:
 ```julia
-julia> BLAS.set_num_threads(TriangularSolve.VectorizationBase.num_cores())
+julia> BLAS.set_num_threads(min(Threads.nthreads(), TriangularSolve.VectorizationBase.num_cores()))
 
 julia> @benchmark TriangularSolve.rdiv!($C, $A, UpperTriangular($B))
 BenchmarkTools.Trial: 10000 samples with 3 evaluations.

src/TriangularSolve.jl

@@ -531,22 +531,24 @@ function __init__()
   end
 end
 
-# let
-#   while true
-#     A = rand(1, 1)
-#     B = rand(1, 1)
-#     res = similar(A)
-#     rdiv!(res, A, UpperTriangular(B))
-#     rdiv!(res, A, UnitUpperTriangular(B))
-#     rdiv!(res, A, UpperTriangular(B), Val(false))
-#     rdiv!(res, A, UnitUpperTriangular(B), Val(false))
-
-#     __init__()
-#     ldiv!(res, LowerTriangular(B), A)
-#     ldiv!(res, UnitLowerTriangular(B), A)
-#     ldiv!(res, LowerTriangular(B), A, Val(false))
-#     ldiv!(res, UnitLowerTriangular(B), A, Val(false))
-#     break
-#   end
-# end
+@static if VERSION >= v"1.8.0-beta1"
+  let
+    while true
+      A = rand(1, 1)
+      B = rand(1, 1)
+      res = similar(A)
+      rdiv!(res, A, UpperTriangular(B))
+      rdiv!(res, A, UnitUpperTriangular(B))
+      rdiv!(res, A, UpperTriangular(B), Val(false))
+      rdiv!(res, A, UnitUpperTriangular(B), Val(false))
+
+      __init__()
+      ldiv!(res, LowerTriangular(B), A)
+      ldiv!(res, UnitLowerTriangular(B), A)
+      ldiv!(res, LowerTriangular(B), A, Val(false))
+      ldiv!(res, UnitLowerTriangular(B), A, Val(false))
+      break
+    end
+  end
+end
 end

test/runtests.jl

@@ -30,5 +30,6 @@ end
 end
 
 using Aqua
-Aqua.test_all(TriangularSolve)
+Aqua.test_all(TriangularSolve, ambiguities=false)
+@test isempty(Test.detect_ambiguities(TriangularSolve))