New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang wrapper for Linux and Windows should set `_GLIBCXX_USE_CXX11_ABI` #290

Closed

giordano opened this issue Jan 4, 2023 · 0 comments · Fixed by #324

Labels

bug 🐛 good first issue linux 🐧 runner 🏃‍♀️ windows 🪟

Member

giordano commented Jan 4, 2023

At the moment

BinaryBuilderBase.jl/src/Runner.jl

Lines 462 to 467 in f782dc5

    
           # Force proper cxx11 string ABI usage w00t w00t! 
        
           if cxxstring_abi(p) == "cxx11" 
        
               push!(flags, "-D_GLIBCXX_USE_CXX11_ABI=1") 
        
           elseif cxxstring_abi(p) == "cxx03" 
        
               push!(flags, "-D_GLIBCXX_USE_CXX11_ABI=0") 
        
           end

is done only for GCC, but it should be done also for Clang on Linux and Windows, since in that case we use libstdc+.

giordano added bug 🐛 good first issue linux 🐧 runner 🏃‍♀️ windows 🪟 labels

gbaraldi mentioned this issue

Add clang-16 #324

Merged

giordano closed this as completed in #324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment