Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency] Add a field to filter platforms where a dependency is used #174

Closed
giordano opened this issue Oct 18, 2021 · 1 comment · Fixed by #176
Closed

[Dependency] Add a field to filter platforms where a dependency is used #174

giordano opened this issue Oct 18, 2021 · 1 comment · Fixed by #176
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@giordano
Copy link
Member

I think it could be useful to have a field to the Dependency struct to filter the platforms where the package will actually be loaded. We can't have platform-dependent dependencies because Pkg doesn't allow it, but we can at least avoid loading them if not necessary, even if they are mostly no-op. For example, GTK3_jll on macOS and Windows could not load the whole X11 stack, and NativeFileDialog_jll could not load GTK3_jll on the same platforms.

CC: @fingolfin

@giordano
Copy link
Member Author

Fixed by #176 and JuliaPackaging/BinaryBuilder.jl#1129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant