decrease max_methods world-splitting setting for some functions

A function which is meant to have methods added to it by users should
have a small `max_methods` value, as world-splitting just leads to
unnecessary invalidation in that case, in the context of the package
ecosystem, where users are allowed to add arbitrarily many methods to
such functions.

xref PR #57884

xref PR #58788

xref PR #58829

xref PR #59091

Author: nsajko

base/Base_compiler.jl

@@ -346,6 +346,8 @@ include("anyall.jl")
 include("ordering.jl")
 using .Order
 
+include("interface_callables_base.jl")
+
 include("coreir.jl")
 include("module.jl")
 

base/abstractarray.jl

@@ -934,10 +934,6 @@ end
 
 ## from general iterable to any array
 
-# This is `Experimental.@max_methods 1 function copyto! end`, which is not
-# defined at this point in bootstrap.
-typeof(function copyto! end).name.max_methods = UInt8(1)
-
 function copyto!(dest::AbstractArray, src)
     destiter = eachindex(dest)
     y = iterate(destiter)

base/broadcast.jl

@@ -1396,4 +1396,9 @@ function Base.show(io::IO, op::BroadcastFunction)
 end
 Base.show(io::IO, ::MIME"text/plain", op::BroadcastFunction) = show(io, op)
 
+# interface callables, like in interface_callables_base.jl, but for `Broadcast` instead of for `Base`.
+for f ∈ Any[broadcastable, instantiate]
+    Base._stable_typeof(f).name.max_methods = 0x1
+end
+
 end # module

base/interface_callables_base.jl

@@ -0,0 +1,48 @@
+# This file is a part of Julia. License is MIT: https://julialang.org/license
+
+# Interface functions defined in `Base`: define any that are not defined yet.
+for c ∈ Symbol[
+    :propertynames, :getproperty, :setproperty!,
+    :show, :print,
+    :nextind, :prevind, :thisind,
+    :length, :iterate, :eltype, :size, :axes, :isdone, :isempty,
+    :firstindex, :lastindex, :getindex, :setindex!,
+    :copy, :copyto!,
+    :isone, :iszero,
+    :strides, :stride, :elsize,
+    :ndims, :one, :zero, :oneunit, :widen,
+    :promote_rule, :convert,
+    :similar,
+    :+, :-, :*, :/, ://, :<<, :>>, :>>>, :div, :fld, :cld,
+]
+    @eval function $c end
+end
+
+# Disable world splitting for callables to which users should add new methods.
+for c ∈ Any[
+    propertynames, getproperty, setproperty!,
+    show, print,
+    nextind, prevind, thisind,
+    length, iterate, size, axes, isdone, isempty,
+    firstindex, lastindex, getindex, setindex!,
+    copy, :copyto!,
+    isone, iszero,
+    strides, stride,
+    +, -, *, /, //, <<, >>, >>>, div, fld, cld,
+]
+    Base._stable_typeof(c).name.max_methods = 0x1
+end
+
+# Callables which take type arguments and need a method for the bottom type need a
+# `max_methods` value of two for good inference, because the bottom type subtypes
+# each type.
+#
+# TODO: add `eltype`
+for c ∈ Any[
+    elsize,
+    ndims, one, zero, oneunit, widen,
+    promote_rule, convert,
+    similar,
+]
+    Base._stable_typeof(c).name.max_methods = 0x2
+end