Skip to content

Commit 7a49be2

Browse files
lbollarandreasnoack
authored andcommitted
added isapprox method for UniformScaling and tests (#18870)
* added isapprox method for UniformScaling and tests
1 parent 11d3c96 commit 7a49be2

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

base/linalg/uniformscaling.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,3 +151,6 @@ inv(J::UniformScaling) = UniformScaling(inv(J.λ))
151151
./(J::UniformScaling,x::Number) = UniformScaling(J.λ/x)
152152

153153
==(J1::UniformScaling,J2::UniformScaling) = (J1.λ == J2.λ)
154+
155+
isapprox{T<:Number,S<:Number}(J1::UniformScaling{T}, J2::UniformScaling{S};
156+
rtol::Real=Base.rtoldefault(T,S), atol::Real=0) = isapprox(J1.λ, J2.λ, rtol=rtol, atol=atol)

test/linalg/uniformscaling.jl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,15 @@ srand(123)
1818
@test -one(UniformScaling(2)) == UniformScaling(-1)
1919
end
2020

21-
@testset "istriu, istril, issymmetric, ishermitian" begin
21+
@testset "istriu, istril, issymmetric, ishermitian, isapprox" begin
2222
@test istriu(I)
2323
@test istril(I)
2424
@test issymmetric(I)
2525
@test issymmetric(UniformScaling(complex(1.0,1.0)))
2626
@test ishermitian(I)
2727
@test !ishermitian(UniformScaling(complex(1.0,1.0)))
28+
@test isapprox(UniformScaling(4.00000000000001), UniformScaling(4.0))
29+
@test isapprox(UniformScaling(4.32), UniformScaling(4.3); rtol=0.1, atol=0.01)
2830
end
2931

3032
@testset "* and / with number" begin

0 commit comments

Comments
 (0)