Skip to content

Commit 2fb61c3

Browse files
authored
Revert "Upgrade and use NSIS for compression instead of extra 7z stag… (#31907)
Revert "Upgrade and use NSIS for compression instead of extra 7z stag…
2 parents 895f40f + 289d5b6 commit 2fb61c3

File tree

5 files changed

+43
-6
lines changed

5 files changed

+43
-6
lines changed

Makefile

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ ifeq ($(DARWIN_FRAMEWORK),1)
421421
endif
422422

423423
distclean:
424-
-rm -fr $(BUILDROOT)/julia-*.tar.gz $(BUILDROOT)/julia*.exe $(BUILDROOT)/julia-$(JULIA_COMMIT)
424+
-rm -fr $(BUILDROOT)/julia-*.tar.gz $(BUILDROOT)/julia*.exe $(BUILDROOT)/julia-*.7z $(BUILDROOT)/julia-$(JULIA_COMMIT)
425425

426426
binary-dist: distclean
427427
ifeq ($(USE_SYSTEM_BLAS),0)
@@ -463,8 +463,13 @@ ifeq ($(OS), WINNT)
463463

464464
# build nsis package
465465
cd $(BUILDROOT) && $(call spawn,$(JULIAHOME)/dist-extras/nsis/makensis.exe) -NOCD -DVersion=$(JULIA_VERSION) -DArch=$(ARCH) -DCommit=$(JULIA_COMMIT) -DMUI_ICON="$(call cygpath_w,$(JULIAHOME)/contrib/windows/julia.ico)" $(call cygpath_w,$(JULIAHOME)/contrib/windows/build-installer.nsi) | iconv -f latin1
466-
mv "$(BUILDROOT)/julia-installer.exe" "$(BUILDROOT)/$(JULIA_BINARYDIST_FILENAME).exe"
466+
467+
# compress nsis installer and combine with 7zip self-extracting header
468+
cd $(BUILDROOT) && $(JULIAHOME)/dist-extras/7z a -mx9 "julia-install-$(JULIA_COMMIT)-$(ARCH).7z" julia-installer.exe
469+
cd $(BUILDROOT) && cat $(JULIAHOME)/contrib/windows/7zS.sfx $(JULIAHOME)/contrib/windows/7zSFX-config.txt "julia-install-$(JULIA_COMMIT)-$(ARCH).7z" > "$(JULIA_BINARYDIST_FILENAME).exe"
467470
chmod a+x "$(BUILDROOT)/$(JULIA_BINARYDIST_FILENAME).exe"
471+
-rm -f $(BUILDROOT)/julia-install-$(JULIA_COMMIT)-$(ARCH).7z
472+
-rm -f $(BUILDROOT)/julia-installer.exe
468473
else
469474
cd $(BUILDROOT) && $(TAR) zcvf $(JULIA_BINARYDIST_FILENAME).tar.gz julia-$(JULIA_COMMIT)
470475
endif
@@ -607,10 +612,10 @@ else
607612
endif
608613
cd $(JULIAHOME)/dist-extras && \
609614
$(JLDOWNLOAD) http://downloads.sourceforge.net/sevenzip/7z1900-extra.7z && \
610-
$(JLDOWNLOAD) https://sourceforge.net/projects/nsis/files/NSIS%203/3.04/nsis-3.04-setup.exe && \
615+
$(JLDOWNLOAD) https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/unsis/nsis-2.46.5-Unicode-setup.exe && \
611616
chmod a+x 7z.exe && \
612617
chmod a+x 7z.dll && \
613-
$(call spawn,./7z.exe) x -y -onsis nsis-3.04-setup.exe && \
618+
$(call spawn,./7z.exe) x -y -onsis nsis-2.46.5-Unicode-setup.exe && \
614619
chmod a+x ./nsis/makensis.exe
615620

616621
# various statistics about the build that may interest the user

contrib/windows/7zS.sfx

178 KB
Binary file not shown.

contrib/windows/7zSFX-config.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
;!@Install@!UTF-8!
2+
Title="The Julia Language"
3+
RunProgram="julia-installer.exe"
4+
;!@InstallEnd@!

contrib/windows/7zSFX-manifest.xml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
2+
<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
3+
<compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
4+
<application>
5+
<!--Windows Vista -->
6+
<supportedOS Id="{e2011457-1546-43c5-a5fe-008deee3d3f0}"/>
7+
<!--Windows 7 -->
8+
<supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}"/>
9+
<!--Windows 8 -->
10+
<supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}"/>
11+
<!--Windows 8.1 and Windows Server 2012 -->
12+
<supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
13+
</application>
14+
</compatibility>
15+
<dependency>
16+
<dependentAssembly>
17+
<assemblyIdentity type="win32" name="Microsoft.Windows.Common-Controls" version="6.0.0.0" processorArchitecture="*" publicKeyToken="6595b64144ccf1df" language="*"/>
18+
</dependentAssembly>
19+
</dependency>
20+
<trustInfo xmlns="urn:schemas-microsoft-com:asm.v3">
21+
<security>
22+
<requestedPrivileges>
23+
<requestedExecutionLevel level="asInvoker" uiAccess="false"/>
24+
</requestedPrivileges>
25+
</security>
26+
</trustInfo>
27+
</assembly>

contrib/windows/build-installer.nsi

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44

55
Name "The Julia Language"
66
OutFile "julia-installer.exe"
7-
SetCompressor /SOLID lzma
8-
SetCompressorDictSize 64
7+
SetCompress off
98
CRCCheck on
109
SetDataBlockOptimize on
1110
ShowInstDetails show
@@ -154,3 +153,5 @@ FunctionEnd
154153
Function ShowInstallFolder
155154
ExecShell "open" $INSTDIR
156155
FunctionEnd
156+
157+

0 commit comments

Comments
 (0)