Merge pull request #31687 from JuliaLang/tb/uncached_codeinst

Fix regressed compilation of uncached code.

Author: maleadt

src/codegen.cpp

@@ -1177,16 +1177,12 @@ jl_code_instance_t *jl_compile_linfo(jl_method_instance_t *mi, jl_code_info_t *s
             jl_ptls_t ptls = jl_get_ptls_states();
             jl_code_instance_t *uncached = (jl_code_instance_t*)jl_gc_alloc(ptls, sizeof(jl_code_instance_t),
                     jl_code_instance_type);
-            uncached->min_world = codeinst->min_world;
-            uncached->max_world = codeinst->max_world;
+            *uncached = *codeinst;
             uncached->functionObjectsDecls.functionObject = NULL;
             uncached->functionObjectsDecls.specFunctionObject = NULL;
-            uncached->rettype = codeinst->rettype;
             uncached->inferred = jl_nothing;
-            uncached->rettype_const = codeinst->rettype_const;
-            uncached->invoke = NULL;
-            if (codeinst->invoke == jl_fptr_const_return)
-                uncached->invoke = jl_fptr_const_return;
+            if (uncached->invoke != jl_fptr_const_return)
+                uncached->invoke = NULL;
             uncached->specptr.fptr = NULL;
             codeinst = uncached;
         }
@@ -3204,6 +3200,7 @@ static jl_cgval_t emit_invoke(jl_codectx_t &ctx, jl_expr_t *ex, jl_value_t *rt)
         assert(jl_is_method_instance(mi));
         jl_code_instance_t *codeinst = jl_compile_linfo(mi, NULL, ctx.world, ctx.params);
         if (codeinst && codeinst->inferred) {
+            JL_GC_PUSH1(&codeinst);
             const jl_llvm_functions_t &decls = codeinst->functionObjectsDecls;
             if (codeinst->invoke == jl_fptr_const_return) {
                 assert(codeinst->rettype_const);
@@ -3219,6 +3216,7 @@ static jl_cgval_t emit_invoke(jl_codectx_t &ctx, jl_expr_t *ex, jl_value_t *rt)
                     handled = true;
                 }
             }
+            JL_GC_POP();
         }
     }
     if (!handled) {

test/reflection.jl

@@ -870,3 +870,15 @@ function _test_at_locals2(a::Any, ::Any)
     @test @locals() == Dict{Symbol,Any}(:x=>2,:a=>a)
 end
 _test_at_locals2(1,1)
+
+@testset "issue #31687" begin
+    import InteractiveUtils._dump_function
+
+    @noinline f31687_child(i) = f31687_nonexistent(i)
+    f31687_parent() = f31687_child(0)
+    params = Base.CodegenParams(cached=false)
+    _dump_function(f31687_parent, Tuple{},
+                   #=native=#false, #=wrapper=#false, #=strip=#false,
+                   #=dump_module=#true, #=syntax=#:att, #=optimize=#false, :none,
+                   params)
+end