You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have bugs involving multi-threading (#963, #990) and should add regressions tests.
However, if I understand this correctly, they could even give a false sense of reliability, as CI runs PackageCompiler.jl single-threaded and so they would appear to succeed even if they would fail in a multi-threaded context. We could run processes we create from PackageCompiler.jl multithreaded, but I think the most realistic use case is to just set JULIA_NUM_THREADS for CI. This way everything in PackageCompiler.jl is automatically tested in a multi-threaded context.
The text was updated successfully, but these errors were encountered:
The benefit of this approach is that the different launch configurations explicitly become part of the test suite, so they won't inadvertently get lost when, say, the package moves to a different CI provider. They also become part of PkgEval runs.
But the best solution is whatever actually gets implemented. I don't use this package myself, just chiming in from the Discourse threads, so I won't put my name down for one or the other.
We have bugs involving multi-threading (#963, #990) and should add regressions tests.
However, if I understand this correctly, they could even give a false sense of reliability, as CI runs
PackageCompiler.jl
single-threaded and so they would appear to succeed even if they would fail in a multi-threaded context. We could run processes we create fromPackageCompiler.jl
multithreaded, but I think the most realistic use case is to just set JULIA_NUM_THREADS for CI. This way everything inPackageCompiler.jl
is automatically tested in a multi-threaded context.The text was updated successfully, but these errors were encountered: