Deprecate Memory(::ByteData) constructor (#219)

nhz2 · web-flow · commit 2e7f5fcb9a45 · 2024-06-24T12:40:14.000-04:00
diff --git a/src/TranscodingStreams.jl b/src/TranscodingStreams.jl
@@ -16,6 +16,7 @@ include("stream.jl")
 include("io.jl")
 include("noop.jl")
 include("transcode.jl")
+include("deprecated.jl")
 
 function test_roundtrip_read end
 function test_roundtrip_write end
diff --git a/src/deprecated.jl b/src/deprecated.jl
@@ -0,0 +1 @@
+Base.@deprecate Memory(data::ByteData) Memory(pointer(data), sizeof(data)) false
diff --git a/src/memory.jl b/src/memory.jl
@@ -11,11 +11,6 @@ struct Memory
     size::UInt
 end
 
-# TODO remove this method
-function Memory(data::ByteData)
-    return Memory(pointer(data), sizeof(data))
-end
-
 @inline function Base.length(mem::Memory)
     return mem.size
 end

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Base.@deprecate Memory(data::ByteData) Memory(pointer(data), sizeof(data)) false`