Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Move autogenerated FHIR types to a separate package #160

Open
devmotion opened this issue Jan 18, 2024 · 4 comments
Open

Suggestion: Move autogenerated FHIR types to a separate package #160

devmotion opened this issue Jan 18, 2024 · 4 comments

Comments

@devmotion
Copy link
Member

devmotion commented Jan 18, 2024

The autogenerated FHIR types are not required for the core functionality of FHIRClient, and additionally the file with the autogenerated FHIR types is extremely large (which means unnecessary parsing and precompilation in case they are not used). I think we could maybe strip down the package and move the autogenerated types to a separate package - only the downstream users that do not define their own FHIR types have to depend on it and load it. Moreover, FHIR types for other FHIR versions could be defined in additional packages.

@DilumAluthge
Copy link
Member

DilumAluthge commented Jan 19, 2024

Yeah, this sounds like a good plan to me.

@DilumAluthge
Copy link
Member

Maybe JuliaHealth/FHIRTypes.jl or something like that?

@devmotion
Copy link
Member Author

Or maybe JuliaHealth/FHIRR4Types.jl or something similar to make it clear that they are for version R4 (but that is only useful if there are plans to support multiple versions at some point)?

@DilumAluthge
Copy link
Member

I was thinking we'd have a single package named JuliaHealth/FHIRTypes.jl, and then within the package, we could support multiple FHIR versions as different submodules, so e.g. FHIRTypes.R4 versus FHIRTypes.R5 versus etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants