Add docker build #342
Open
Add docker build #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Dec 13, 2017
travis-script.sh
Outdated
| set -ex | ||
|
|
||
| if [[ -a .git/shallow ]]; then | ||
| git fetch --unshallow |
Contributor
There was a problem hiding this comment.
I'm not sure why we need git history, but perhaps it would be faster to set this from the travis file:
git:
depth: 2147483647
Contributor
Author
There was a problem hiding this comment.
Yeah, that's probably left over from the old PkgDev templates which did this. Your way is nicer.
Contributor
Author
|
Ok, docker build is working now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrates adding Docker build from #341
Probably won't work right away, since I'm guessing about the Travis commands a little bit.