-
Notifications
You must be signed in to change notification settings - Fork 152
sortperm is unstable #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
stev47
added a commit
to stev47/StaticArrays.jl
that referenced
this issue
Dec 4, 2020
We reverse the order as part of the bitonic sort algorithm, but `ReverseOrdering` is not the true reverse order for an order `<:Perm`. This led to non-stable sorting for `sortperm`. Fixed by hand-wiring the reversal. Fixes JuliaArrays#858.
stev47
added a commit
to stev47/StaticArrays.jl
that referenced
this issue
Dec 4, 2020
We reverse the order as part of the bitonic sort algorithm, but `ReverseOrdering` is not the true reverse order for an order `::Perm`. This led to non-stable sorting for `sortperm`. Fixed by hand-wiring the reversal. Fixes JuliaArrays#858.
stev47
added a commit
to stev47/StaticArrays.jl
that referenced
this issue
Dec 4, 2020
We reverse the order as part of the bitonic sort algorithm, but `ReverseOrdering` is not the true reverse order for an order `::Perm`. This led to non-stable sorting for `sortperm`. Fixed by hand-wiring the reversal. Fixes JuliaArrays#858.
c42f
pushed a commit
that referenced
this issue
Jan 17, 2021
We reverse the order as part of the bitonic sort algorithm, but `ReverseOrdering` is not the true reverse order for an order `::Perm`. This led to non-stable sorting for `sortperm`. Fixed by hand-wiring the reversal. Fixes #858.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
?sortperm
saysI am not sure if the algorithm in #773 is meant to be stable, but for StaticArrays v1.0.0,
The text was updated successfully, but these errors were encountered: