eltype bugfix in default_BlockMatrix (#402)

* eltype bugfix in default_BlockMatrix

* import packages

Author: jishnub

Project.toml

@@ -1,6 +1,6 @@
 name = "ApproxFunBase"
 uuid = "fbd15aa5-315a-5a7d-a8a4-24992e37be05"
-version = "0.8.4"
+version = "0.8.5"
 
 [deps]
 AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c"

src/Operators/Operator.jl

@@ -765,7 +765,7 @@ function BlockBandedMatrix(S::Operator)
 end
 
 function default_BlockMatrix(S::Operator)
-    ret = PseudoBlockArray(zeros(size(S)),
+    ret = PseudoBlockArray(zeros(eltype(S), size(S)),
                         AbstractVector{Int}(blocklengths(rangespace(S))),
                         AbstractVector{Int}(blocklengths(domainspace(S))))
     ret .= S

test/runtests.jl

@@ -2,6 +2,8 @@ using ApproxFunBase
 using ApproxFunBase: ∞
 using Aqua
 using BandedMatrices
+using BlockArrays
+using BlockBandedMatrices
 using DomainSets
 using FillArrays
 using InfiniteArrays
@@ -359,6 +361,21 @@ end
         ApproxFunBase.mul_coefficients!(Operator(2I), v)
         @test v ≈ Float64[2i^2 for i in 1:4]
     end
+    @testset "Matrix types" begin
+        F = Multiplication(Fun(PointSpace(1:3)), PointSpace(1:3))
+        function test_matrices(F)
+            A = AbstractMatrix(F)
+            @test Matrix(F) == BandedMatrix(F) == BlockBandedMatrix(F) == ApproxFunBase.RaggedMatrix(F) == A
+            DefBlk = ApproxFunBase.default_BlockMatrix(F)
+            DefBBlk = ApproxFunBase.default_BlockBandedMatrix(F)
+            DefB = ApproxFunBase.default_BandedMatrix(F)
+            DefM = ApproxFunBase.default_Matrix(F)
+            DefR = ApproxFunBase.default_RaggedMatrix(F)
+            @test DefBlk == DefBBlk == DefB == DefM == DefR == A
+        end
+        test_matrices(F)
+        test_matrices(im*F)
+    end
 end
 
 @testset "RowVector" begin