Merge pull request #296 from alan-turing-institute/drop-mljlinearmodels

Temporarily suspend some testing because of a test pkg conflict

Author: ablaom

Project.toml

@@ -47,11 +47,10 @@ Distances = "b4f34e82-e78d-54a5-968a-f98e89d6e8f7"
 GLM = "38e38edf-8417-5370-95a0-9cbb8c7f171a"
 GaussianProcesses = "891a1506-143c-57d2-908e-e1f8e92e6de9"
 LIBSVM = "b1bec4e5-fd48-53fe-b0cb-9723c09d164b"
-MLJLinearModels = "6ee0df7b-362f-4a72-a706-9e79364fb692"
 NaiveBayes = "9bbee03b-0db5-5f46-924f-b5c9c21b8c60"
 NearestNeighbors = "b8a86587-4115-5ab1-83bc-aa920d37bbce"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 XGBoost = "009559a3-9522-5dbb-924b-0b6ed2b22bb9"
 
 [targets]
-test = ["Clustering", "DecisionTree", "Distances", "GLM", "GaussianProcesses", "LIBSVM", "MLJLinearModels", "NaiveBayes", "NearestNeighbors", "Test", "XGBoost"]
+test = ["Clustering", "DecisionTree", "Distances", "GLM", "GaussianProcesses", "LIBSVM", "NaiveBayes", "NearestNeighbors", "Test", "XGBoost"]

test/loading.jl

@@ -34,15 +34,14 @@ using MLJModels
 
     @test Foo() == RidgeRegressor()
 
-    # load a model with same name from different package:
-    @test_logs (:warn, r"New model type") begin
-         load("RidgeRegressor",
-              pkg="MLJLinearModels",
-              modl=TestLoading,
-              verbosity=0)
-    end
+    # TODO: re-instate when Optim.jl updates its [compat] for FillArrays:
+    # https://github.com/JuliaNLSolvers/Optim.jl/pull/840
+
+    # # load a model with same name from different package: @test_logs
+    # (:warn, r"New model type") begin load("RidgeRegressor",
+    # pkg="MLJLinearModels", modl=TestLoading, verbosity=0) end
 
-    @test typeof(RidgeRegressor2()) != typeof(RidgeRegressor())
+    # @test typeof(RidgeRegressor2()) != typeof(RidgeRegressor())
 
     # try to use the name of an existing object for new type name
     @test_throws Exception load("DecisionTreeClassifier",
@@ -61,4 +60,3 @@ end
 end # module
 
 true
-