support the loading of addons generators and decorators.

all sonar violations removed.

Author: Z7oussem

src/main/java/io/asfjava/ui/core/GeneratorFactoryLoader.java

@@ -2,22 +2,30 @@
 
 import static io.asfjava.ui.core.logging.ErrorCode.ASF01;
 
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
 import org.reflections.Reflections;
 
 import io.asfjava.ui.core.generators.FormDefinitionGenerator;
 import io.asfjava.ui.core.logging.ASFUILogger;
 
 final class GeneratorFactoryLoader {
-	private static final String PACKAGESCAN = "io.asfjava.ui.core.generators";
+	private static final List<String> PACKAGESCAN = Stream
+			.of("io.asfjava.ui.core.generators", "io.asfjava.ui.addons.generators").collect(Collectors.toList());
 	private static Reflections reflections = new Reflections(PACKAGESCAN);
 
 	void load() {
-		reflections.getSubTypesOf(FormDefinitionGenerator.class).stream().forEach(subtype -> register(subtype));
+		for (Class<? extends FormDefinitionGenerator> subType : reflections
+				.getSubTypesOf(FormDefinitionGenerator.class)) {
+			register(subType);
+		}
 	}
 
-	private void register(Class<? extends FormDefinitionGenerator> subtype) {
+	private void register(Class<? extends FormDefinitionGenerator> subType) {
 		try {
-			FormDefinitionGenerator formDefinitionGenerator = subtype.newInstance();
+			FormDefinitionGenerator formDefinitionGenerator = subType.newInstance();
 			FormDefinitionGeneratorFactory.getInstance().register(formDefinitionGenerator::getAnnotation,
 					formDefinitionGenerator);
 		} catch (InstantiationException | IllegalAccessException e) {

src/main/java/io/asfjava/ui/core/SchemaDecoratorLoader.java

@@ -2,23 +2,31 @@
 
 import static io.asfjava.ui.core.logging.ErrorCode.ASF01;
 
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
 import org.reflections.Reflections;
 
 import io.asfjava.ui.core.logging.ASFUILogger;
 import io.asfjava.ui.core.schema.decorators.SchemaDecorator;
 
 final class SchemaDecoratorLoader {
 
-	private static final String PACKAGESCAN = "io.asfjava.ui.core.schema.decorators";
+	private static final List<String> PACKAGESCAN = Stream
+			.of("io.asfjava.ui.core.schema.decorators", "io.asfjava.ui.addons.schema.decorators")
+			.collect(Collectors.toList());
 	private static Reflections reflections = new Reflections(PACKAGESCAN);
 
 	void load() {
-		reflections.getSubTypesOf(SchemaDecorator.class).stream().forEach(subtype -> register(subtype));
+		for (Class<? extends SchemaDecorator> subType : reflections.getSubTypesOf(SchemaDecorator.class)) {
+			register(subType);
+		}
 	}
 
-	private void register(Class<? extends SchemaDecorator> subtype) {
+	private void register(Class<? extends SchemaDecorator> subType) {
 		try {
-			SchemaDecorator decorator = subtype.newInstance();
+			SchemaDecorator decorator = subType.newInstance();
 			SchemaDecoratorFactory.getInstance().register(decorator::getAnnotation, decorator);
 		} catch (InstantiationException | IllegalAccessException e) {
 			ASFUILogger.getLogger().error(ASF01, e);
@@ -30,12 +38,12 @@ void unload() {
 	}
 
 	static SchemaDecoratorLoader getInstance() {
-		if (INSTANCE == null)
-			INSTANCE = new SchemaDecoratorLoader();
-		return INSTANCE;
+		if (instance == null)
+			instance = new SchemaDecoratorLoader();
+		return instance;
 	}
 
-	private static SchemaDecoratorLoader INSTANCE;
+	private static SchemaDecoratorLoader instance;
 
 	private SchemaDecoratorLoader() {
 	}

src/main/java/io/asfjava/ui/core/generators/CheckBoxGenerator.java

@@ -40,15 +40,18 @@ public void generate(ObjectNode fieldFormDefinition, Field field) {
 				fieldFormDefinition.set("titleMap", titlesMap);
 			} catch (InstantiationException | IllegalAccessException e) {
 				ASFUILogger.getLogger().error(e.getMessage());
+				throw new RuntimeException(e);
 			}
 		}
 	}
 
 	private void buildValueDefinition(ObjectMapper checkBoxMapper, ArrayNode titlesMap, String value) {
 		ObjectNode entry = checkBoxMapper.createObjectNode();
-		if (value.equals(value.toUpperCase())) {
+		String upperCasedValue = value.toUpperCase();
+		String lowerCasedValue = value.toLowerCase();
+		if (value.equals(upperCasedValue)) {
 			entry.put("name", value.toLowerCase());
-		} else if (value.equals(value.toLowerCase())) {
+		} else if (value.equals(lowerCasedValue)) {
 			entry.put("name", value.replace(value.substring(0, 1), value.substring(0, 1).toUpperCase()));
 		} else {
 			entry.put("name", value);

src/main/java/io/asfjava/ui/core/schema/UiFormSchemaGenerator.java

@@ -17,7 +17,7 @@
 
 public final class UiFormSchemaGenerator {
 
-	private static UiFormSchemaGenerator INSTANCE;
+	private static UiFormSchemaGenerator instance;
 
 	public UiForm generate(Class<? extends Serializable> formDto) throws JsonMappingException {
 		ObjectMapper mapper = new ObjectMapper();
@@ -47,10 +47,10 @@ private void buildFieldDefinition(Field field, Annotation annotation, ObjectMapp
 	}
 
 	public static UiFormSchemaGenerator get() {
-		if (INSTANCE == null) {
-			INSTANCE = new UiFormSchemaGenerator();
+		if (instance == null) {
+			instance = new UiFormSchemaGenerator();
 		}
-		return INSTANCE;
+		return instance;
 	}
 
 	private UiFormSchemaGenerator() {