Skip to content

Commit 305571f

Browse files
committed
✅ increase UT Coverage
Our goal is 100% coverage
1 parent 871652e commit 305571f

File tree

6 files changed

+206
-125
lines changed

6 files changed

+206
-125
lines changed

src/main/java/io/asfjava/ui/core/logging/ASFUILogger.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,12 @@
55

66
public final class ASFUILogger {
77

8-
private final static Logger LOGGER=LoggerFactory.getLogger("ASFUILogger");
9-
public static Logger getLogger(){
8+
private final static Logger LOGGER = LoggerFactory.getLogger("ASFUILogger");
9+
10+
public static Logger getLogger() {
1011
return LOGGER;
1112
}
12-
13+
1314
private ASFUILogger() {
1415
}
1516

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
package io.asfjava.ui.core.logging;
22

33
public final class ErrorCode {
4-
public final static String ASF01="Failure when trying to load Generators";
5-
public final static String ASF02="Failure when trying to load Decorators";
6-
private ErrorCode(){
7-
8-
}
4+
public final static String ASF01 = "Failure when trying to load Generators";
5+
public final static String ASF02 = "Failure when trying to load Decorators";
6+
7+
private ErrorCode() {
8+
9+
}
910
}

src/main/java/io/asfjava/ui/core/schema/CustomSchemaFactoryWrapper.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,6 @@
88
class CustomSchemaFactoryWrapper extends SchemaFactoryWrapper {
99

1010
private static class SFSchemaFactoryWrapperFactory extends WrapperFactory {
11-
@Override
12-
public SchemaFactoryWrapper getWrapper(SerializerProvider p) {
13-
SchemaFactoryWrapper wrapper = new CustomSchemaFactoryWrapper();
14-
if (p != null) {
15-
wrapper.setProvider(p);
16-
}
17-
return wrapper;
18-
}
1911

2012
@Override
2113
public SchemaFactoryWrapper getWrapper(SerializerProvider p, VisitorContext rvc) {

src/main/java/io/asfjava/ui/core/schema/decorators/NumberSchemaDecorator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import com.fasterxml.jackson.databind.BeanProperty;
44
import com.fasterxml.jackson.module.jsonSchema.JsonSchema;
5-
import com.fasterxml.jackson.module.jsonSchema.types.StringSchema;
5+
import com.fasterxml.jackson.module.jsonSchema.types.SimpleTypeSchema;
66

77
import io.asfjava.ui.core.form.Number;
88

@@ -12,7 +12,7 @@ public class NumberSchemaDecorator implements SchemaDecorator {
1212
public void customizeSchema(BeanProperty property, JsonSchema jsonschema) {
1313
Number annotation = property.getAnnotation(Number.class);
1414
if (annotation != null && annotation.title() != null) {
15-
((StringSchema) jsonschema).setTitle(annotation.title());
15+
((SimpleTypeSchema) jsonschema).setTitle(annotation.title());
1616
}
1717
}
1818

src/main/java/io/asfjava/ui/dto/UiForm.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ public class UiForm implements Serializable {
1111
private ArrayNode form;
1212

1313
public UiForm(JsonSchema schema, ArrayNode form) {
14-
this.schema = schema;
15-
this.form = form;
14+
setSchema(schema);
15+
setForm(form);
1616
}
1717

1818
public JsonSchema getSchema() {

0 commit comments

Comments
 (0)