Skip to content

Commit c84c9f3

Browse files
committed
fix(entrypoint): nginx crashes when overriding default.conf
fixes #247 closes #251
1 parent 1939b47 commit c84c9f3

7 files changed

+10
-8
lines changed

Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ ENV NGINX_LISTEN_PORT '80'
2323
ENV SHOW_CATALOG_NB_TAGS 'false'
2424

2525
COPY nginx/default.conf /etc/nginx/conf.d/default.conf
26-
COPY bin/entrypoint /docker-entrypoint.d/90-docker-registry-ui.sh
26+
COPY bin/90-docker-registry-ui.sh /docker-entrypoint.d/90-docker-registry-ui.sh
2727
COPY dist/ /usr/share/nginx/html/
2828
COPY favicon.ico /usr/share/nginx/html/
2929

arm32v7.dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ ENV NGINX_LISTEN_PORT '80'
2323
ENV SHOW_CATALOG_NB_TAGS 'false'
2424

2525
COPY nginx/default.conf /etc/nginx/conf.d/default.conf
26-
COPY bin/entrypoint /docker-entrypoint.d/90-docker-registry-ui.sh
26+
COPY bin/90-docker-registry-ui.sh /docker-entrypoint.d/90-docker-registry-ui.sh
2727
COPY dist/ /usr/share/nginx/html/
2828
COPY favicon.ico /usr/share/nginx/html/
2929

arm64v8.dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ ENV NGINX_LISTEN_PORT '80'
2323
ENV SHOW_CATALOG_NB_TAGS 'false'
2424

2525
COPY nginx/default.conf /etc/nginx/conf.d/default.conf
26-
COPY bin/entrypoint /docker-entrypoint.d/90-docker-registry-ui.sh
26+
COPY bin/90-docker-registry-ui.sh /docker-entrypoint.d/90-docker-registry-ui.sh
2727
COPY dist/ /usr/share/nginx/html/
2828
COPY favicon.ico /usr/share/nginx/html/
2929

bin/entrypoint bin/90-docker-registry-ui.sh

+4-2
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,13 @@ if [ -n "${NGINX_PROXY_PASS_URL}" ] ; then
5858
fi
5959

6060
if [ "$(whoami)" != "root" ]; then
61-
if [ "$NGINX_LISTEN_PORT" = 80 ]; then
61+
if [ "$NGINX_LISTEN_PORT" = "80" ]; then
6262
NGINX_LISTEN_PORT="8080"
6363
fi
6464
sed -i "/user nginx;/d" /etc/nginx/nginx.conf
6565
sed -i "s,/var/run/nginx.pid,/tmp/nginx.pid," /etc/nginx/nginx.conf
6666
fi
6767

68-
sed -i "s,listen 80;,listen $NGINX_LISTEN_PORT;," /etc/nginx/conf.d/default.conf
68+
if [ "$NGINX_LISTEN_PORT" != "80" ]; then
69+
sed -i "s,listen 80;,listen $NGINX_LISTEN_PORT;," /etc/nginx/conf.d/default.conf
70+
fi

debian.dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ ENV NGINX_LISTEN_PORT '80'
2323
ENV SHOW_CATALOG_NB_TAGS 'false'
2424

2525
COPY nginx/default.conf /etc/nginx/conf.d/default.conf
26-
COPY bin/entrypoint /docker-entrypoint.d/90-docker-registry-ui.sh
26+
COPY bin/90-docker-registry-ui.sh /docker-entrypoint.d/90-docker-registry-ui.sh
2727
COPY dist/ /usr/share/nginx/html/
2828
COPY favicon.ico /usr/share/nginx/html/
2929

dist/docker-registry-ui.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "docker-registry-ui",
3-
"version": "2.2.0",
3+
"version": "2.2.1",
44
"scripts": {
55
"format": "npm run format-html && npm run format-js && npm run format-riot",
66
"format-html": "find src rollup rollup.config.js -name '*.html' -exec prettier --config .prettierrc -w --parser html {} \\;",

0 commit comments

Comments
 (0)