{monitor} fix dynamic metric alert creation with a single scope (Azure#16225)

* fix dynamic metric alert creation with a single scope

* fix style issues

Author: kairu-ms

.ionide/symbolCache.db

@@ -2,6 +2,7 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License. See License.txt in the project root for license information.
 # --------------------------------------------------------------------------------------------
+# pylint: disable=too-many-locals
 
 from azure.cli.command_modules.monitor.util import get_operator_map, get_aggregation_map
 from knack.log import get_logger
@@ -16,7 +17,8 @@ def create_metric_alert(client, resource_group_name, rule_name, scopes, conditio
                         auto_mitigate=None, target_resource_type=None, target_resource_region=None):
     from azure.mgmt.monitor.models import (MetricAlertResource,
                                            MetricAlertSingleResourceMultipleMetricCriteria,
-                                           MetricAlertMultipleResourceMultipleMetricCriteria)
+                                           MetricAlertMultipleResourceMultipleMetricCriteria,
+                                           MetricCriteria)
     from azure.cli.core import CLIError
     # generate names for the conditions
     for i, cond in enumerate(condition):
@@ -28,7 +30,7 @@ def create_metric_alert(client, resource_group_name, rule_name, scopes, conditio
             raise CLIError('--target-resource-type and --target-resource-region must be provided.')
         criteria = MetricAlertMultipleResourceMultipleMetricCriteria(all_of=condition)
     else:
-        if len(scopes) == 1:
+        if len(scopes) == 1 and isinstance(condition, MetricCriteria):
             criteria = MetricAlertSingleResourceMultipleMetricCriteria(all_of=condition)
         else:
             criteria = MetricAlertMultipleResourceMultipleMetricCriteria(all_of=condition)

src/azure-cli/azure/cli/command_modules/monitor/operations/metric_alert.py

@@ -265,6 +265,42 @@ def test_metric_alert_multiple_scopes(self, resource_group, vm1, vm2):
             self.check('length(scopes)', 2),
         ])
 
+    @ResourceGroupPreparer(name_prefix='cli_test_dynamic_metric_alert')
+    @VMPreparer(parameter_name='vm1')
+    def test_dynamic_metric_alert_basic(self, resource_group, vm1):
+        from azure.mgmt.core.tools import resource_id
+        self.kwargs.update({
+            'alert': 'alert1',
+            'plan': 'plan1',
+            'app': self.create_random_name('app', 15),
+            'ag1': 'ag1',
+            'webhooks': '{{test=banoodle}}',
+            'sub': self.get_subscription_id(),
+            'vm_id': resource_id(
+                resource_group=resource_group,
+                subscription=self.get_subscription_id(),
+                name=vm1,
+                namespace='Microsoft.Compute',
+                type='virtualMachines'),
+        })
+        self.cmd('monitor action-group create -g {rg} -n {ag1}')
+        self.cmd(
+            'monitor metrics alert create -g {rg} -n {alert} --scopes {vm_id} --action {ag1} --condition "avg Percentage CPU > dynamic low 2 of 4 since 2020-11-01T16:00:00.000Z" --description "High CPU"',
+            checks=[
+                self.check('description', 'High CPU'),
+                self.check('severity', 2),
+                self.check('autoMitigate', None),
+                self.check('windowSize', '0:05:00'),
+                self.check('evaluationFrequency', '0:01:00'),
+                self.check('length(scopes)', 1),
+                self.check('criteria.allOf[0].alertSensitivity', 'Low'),
+                self.check('criteria.allOf[0].criterionType', 'DynamicThresholdCriterion'),
+                self.check('criteria.allOf[0].failingPeriods.minFailingPeriodsToAlert', 2.0),
+                self.check('criteria.allOf[0].failingPeriods.numberOfEvaluationPeriods', 4.0),
+                self.check('criteria.allOf[0].operator', 'GreaterThan'),
+                self.check('criteria.allOf[0].ignoreDataBefore', '2020-11-01T16:00:00+00:00')
+            ])
+
     @ResourceGroupPreparer(name_prefix='cli_test_dynamic_metric_alert_v2')
     @VMPreparer(parameter_name='vm1')
     @VMPreparer(parameter_name='vm2')