Skip to content

Commit d70dc32

Browse files
Avoid some unnecessary buffering when reading config file (sqlc-dev#2215)
1 parent 8fbe520 commit d70dc32

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

internal/cmd/generate.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,13 +100,14 @@ func readConfig(stderr io.Writer, dir, filename string) (string, *config.Config,
100100
}
101101

102102
base := filepath.Base(configPath)
103-
blob, err := os.ReadFile(configPath)
103+
file, err := os.Open(configPath)
104104
if err != nil {
105105
fmt.Fprintf(stderr, "error parsing %s: file does not exist\n", base)
106106
return "", nil, err
107107
}
108+
defer file.Close()
108109

109-
conf, err := config.ParseConfig(bytes.NewReader(blob))
110+
conf, err := config.ParseConfig(file)
110111
if err != nil {
111112
switch err {
112113
case config.ErrMissingVersion:

0 commit comments

Comments
 (0)