The icon for the plugin does not show up in the address bar, but rather only as a plugin icon.

[derickr]

Describe the bug
The old helper would show up in the address bar, right next to the star icon (to bookmark). This new one only shows up when you click on the "Extension" (puzzle piece) icon. It is possible to pin it to the toolbar, but not in the same place as the original extension did.

To Reproduce
Steps to reproduce the behavior:

1. Install the extension
2. See where it shows up (in the Extensions Icon drop down)

Expected behavior
A way of getting it back in the address bar.
ain your problem.

Desktop (please complete the following information):

• Linux Debian Unstable (irrelevant)
• Firefox
• 129.0.2

[FraserChapman]

Hi @derickr - As you say you should be able to pin it, but you should also be able to position it anywhere that a control is valid. e.g.

If that isn't what you mean, could you grab a screenshot of the icon in the position you are talking about? It could be there is some manifest trick to this I am not aware of if you mean inside the actual address input.

[derickr]

It's not what I meant. I can indeed pin it, next to the address bar. The earlier one was in the address bar.

[FraserChapman]

Ah ok, thanks for the clarification - will have to take a look how that is handled!

[derickr]

I did try to compare the manifests, but the only big thing looked to be the manifest version (2 vs 3)

[FraserChapman]

It needs testing but I think this can be resolved with something like changing...

"action": {
    "default_popup": "popup.html"
}

to

"page_action": {
    "default_icon": "img/disable16.png",
    "default_popup": "popup.html",
    "show_matches": [
            "http://*/*",
            "https://*/*"
        ]
}

in the manifest...I would need to look into it more, it could be mozilla specific, etc - but that seems to be it :)

See https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/page_action

[derickr]

I think the old code has this: "show_matches" : [ "*://*/*" ] But besides that, how would I test this?

[FraserChapman]

I actually have a draft PR with the changes made, so you could just pull that run the build on it.

#19

To test, you would go to that branch and..

1. Run the build script
2. Go to about:debugging in FireFox
3. Select "This Firefox"
4. Choose "Load Temporary Add-on"
5. Select the XPI file that was created in step 1

As an aside the old code with: "show_matches" : [ "*://*/*" ] is odd...In that the match pattern "*://*/*" wouldn't make sense for a page_action because it matches every protocol (about:, file:, chrome:, etc) . If it truly should be there for the browser as a whole in any context it should be a action with a default_area not a page_action

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/action

[derickr]

I've tried this out, and it works — I see it in the address bar again!