Skip to content

Commit 30554c0

Browse files
committed
Fix line mapping toString
1 parent c29c0d9 commit 30554c0

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

instrumentation/src/com/intellij/rt/coverage/instrumentation/BranchesEnumerator.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,9 @@ public void visitJumpInsn(final int opcode, final Label label) {
8383
if (opcode != Opcodes.GOTO && opcode != Opcodes.JSR && !InstrumentationUtils.CLASS_INIT.equals(myMethodName)) {
8484
final LineData lineData = myInstrumenter.getLineData(myCurrentLine);
8585
if (lineData != null) {
86-
int currentJump = lineData.jumpsCount();
8786
Label trueLabel = new Label();
8887
Label falseLabel = new Label();
89-
myBranchData.addJump(lineData, currentJump, trueLabel, falseLabel);
88+
myBranchData.addJump(lineData, trueLabel, falseLabel);
9089
onNewJump(label, trueLabel, falseLabel);
9190

9291
jumpInstrumented = true;
@@ -117,7 +116,7 @@ private SwitchLabels replaceLabels(SwitchLabels original, LineData lineData, int
117116
super.visitJumpInsn(Opcodes.GOTO, beforeSwitchLabel);
118117

119118
final SwitchLabels replacement = new SwitchLabels(newDefaultLabel, newLabels);
120-
myBranchData.addSwitch(lineData, lineData.switchesCount(), newDefaultLabel, keys, newLabels);
119+
myBranchData.addSwitch(lineData, keys, newDefaultLabel, newLabels);
121120
onNewSwitch(original, replacement);
122121

123122
for (int i = 0; i < newLabels.length; i++) {

instrumentation/src/com/intellij/rt/coverage/instrumentation/data/BranchDataContainer.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ public void addLine(LineData lineData) {
7979
}
8080
}
8181

82-
public void addJump(LineData lineData, int index, Label trueLabel, Label falseLabel) {
82+
public void addJump(LineData lineData, Label trueLabel, Label falseLabel) {
83+
int index = lineData.jumpsCount();
8384
int line = lineData.getLineNumber();
8485
// jump type is inverted as jump occurs if value is true
8586
Jump trueJump = new Jump(incrementId(), index, line, false);
@@ -96,7 +97,8 @@ public void addJump(LineData lineData, int index, Label trueLabel, Label falseLa
9697
jumpData.setId(falseJump.getId(), falseJump.getType());
9798
}
9899

99-
public void addSwitch(LineData lineData, int index, Label dflt, int[] keys, Label[] labels) {
100+
public void addSwitch(LineData lineData, int[] keys, Label dflt, Label[] labels) {
101+
final int index = lineData.switchesCount();
100102
List<Switch> switches = rememberSwitchLabels(lineData.getLineNumber(), dflt, labels, index);
101103
SwitchData switchData = lineData.addSwitch(index, keys);
102104
setSwitchIds(switchData, switches);

util/src/com/intellij/rt/coverage/data/LineMapData.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public int getMappingEnd(int index) {
6060
}
6161

6262
public String toString() {
63-
return "map [" + myMappedStart + "; " + myMappedStart + myCount * myIncrement + ") to [" + mySourceStart + "; " + mySourceStart + myCount + ")";
63+
return "map [" + myMappedStart + "; " + (myMappedStart + myCount * myIncrement) + ") to [" + mySourceStart + "; " + (mySourceStart + myCount) + ")";
6464
}
6565

6666
private void checkIndex(int index) {

0 commit comments

Comments
 (0)