Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pep8ify sessions #3

Open
JayToTheAy opened this issue Nov 17, 2024 · 0 comments
Open

pep8ify sessions #3

JayToTheAy opened this issue Nov 17, 2024 · 0 comments
Labels
enhancement New feature or request pep8 compliance Comply with pep8, dummy standards
Milestone
1.0.0

Comments

@JayToTheAy
Copy link
Owner

JayToTheAy commented Nov 17, 2024 •
edited
Loading

Currently, I'm doing with self.session as s in a lot of places, which isn't pep8 compliant -- we're not acquiring and then releasing a resource. It should just be a self.session.get wherever I use it from once -- maybe even just a normal request.get.

Maybe also do a .close on some mythical .logout() method?
@JayToTheAy JayToTheAy added enhancement New feature or request pep8 compliance Comply with pep8, dummy labels Nov 17, 2024
@JayToTheAy JayToTheAy added this to the 1.0.0 milestone Nov 17, 2024
@JayToTheAy JayToTheAy changed the title pip8ify sessions pep8ify sessions Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request pep8 compliance Comply with pep8, dummy standards
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@JayToTheAy