Automatic cleanup - instanceof pattern matching in Debug.core

This commit implements automatic cleanup using instanceof pattern
matching in the debug.core package of the platform debug module.

Author: SougandhS

debug/org.eclipse.debug.core/core/org/eclipse/debug/core/DebugPlugin.java

@@ -1272,8 +1272,7 @@ public int hashCode() {
 
 		@Override
 		public boolean equals(Object obj) {
-			if (obj instanceof StatusHandlerKey) {
-				StatusHandlerKey s = (StatusHandlerKey)obj;
+			if (obj instanceof StatusHandlerKey s) {
 				return fCode == s.fCode && fPluginId.equals(s.fPluginId);
 			}
 			return false;

debug/org.eclipse.debug.core/core/org/eclipse/debug/core/Launch.java

@@ -527,10 +527,9 @@ public void disconnect() throws DebugException {
 		readLock.lock();
 		try {
 			for (IProcess process : getProcesses0()) {
-				if (process instanceof IDisconnect) {
-					IDisconnect dis = (IDisconnect) process;
-					if (dis.canDisconnect()) {
-						dis.disconnect();
+				if (process instanceof IDisconnect disc) {
+					if (disc.canDisconnect()) {
+						disc.disconnect();
 					}
 				}
 			}

debug/org.eclipse.debug.core/core/org/eclipse/debug/core/commands/AbstractDebugCommand.java

@@ -187,8 +187,7 @@ public boolean contains(ISchedulingRule rule) {
 
 		@Override
 		public boolean isConflicting(ISchedulingRule rule) {
-			if (rule instanceof SerialPerObjectRule) {
-				SerialPerObjectRule vup = (SerialPerObjectRule) rule;
+			if (rule instanceof SerialPerObjectRule vup) {
 				return fObject == vup.fObject;
 			}
 			return false;

debug/org.eclipse.debug.core/core/org/eclipse/debug/core/sourcelookup/AbstractSourceLookupDirector.java

@@ -474,8 +474,7 @@ protected List<Object> doSourceLookup(Object element) {
 		List<Object> sources = query.getSourceElements();
 		Throwable exception = query.getException();
 		if (exception != null) {
-			if (exception instanceof CoreException) {
-				CoreException ce = (CoreException) exception;
+			if (exception instanceof CoreException ce) {
 				if (ce.getStatus().getSeverity() == IStatus.ERROR) {
 					DebugPlugin.log(ce);
 				}

debug/org.eclipse.debug.core/core/org/eclipse/debug/core/sourcelookup/containers/AbstractSourceContainer.java

@@ -109,11 +109,9 @@ protected ISourceLookupDirector getDirector() {
 	protected boolean isFindDuplicates() {
 		ISourceLookupDirector director = getDirector();
 		if (director != null) {
-			if (director instanceof AbstractSourceLookupDirector) {
-				AbstractSourceLookupDirector asld = (AbstractSourceLookupDirector) director;
+			if (director instanceof AbstractSourceLookupDirector asld) {
 				ISourceLookupParticipant participant = asld.getCurrentParticipant();
-				if (participant instanceof AbstractSourceLookupParticipant	) {
-					AbstractSourceLookupParticipant aslp = (AbstractSourceLookupParticipant) participant;
+				if (participant instanceof AbstractSourceLookupParticipant aslp	) {
 					return aslp.isFindDuplicates();
 				}
 			}

debug/org.eclipse.debug.core/core/org/eclipse/debug/core/sourcelookup/containers/ContainerSourceContainer.java

@@ -148,8 +148,7 @@ public String getName() {
 
 	@Override
 	public boolean equals(Object obj) {
-		if (obj != null && obj instanceof ContainerSourceContainer) {
-			ContainerSourceContainer loc = (ContainerSourceContainer) obj;
+		if (obj != null && obj instanceof ContainerSourceContainer loc) {
 			return loc.getContainer().equals(getContainer());
 		}
 		return false;

debug/org.eclipse.debug.core/core/org/eclipse/debug/core/sourcelookup/containers/DirectorySourceContainer.java

@@ -132,8 +132,7 @@ public boolean isComposite() {
 
 	@Override
 	public boolean equals(Object obj) {
-		if (obj instanceof DirectorySourceContainer) {
-			DirectorySourceContainer container = (DirectorySourceContainer) obj;
+		if (obj instanceof DirectorySourceContainer container) {
 			return container.getDirectory().equals(getDirectory());
 		}
 		return false;

debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/LaunchManager.java

@@ -356,8 +356,7 @@ public boolean visit(IResourceDelta delta) {
 				return false;
 			}
 			IResource resource = delta.getResource();
-			if (resource instanceof IFile) {
-				IFile file = (IFile)resource;
+			if (resource instanceof IFile file) {
 				if (ILaunchConfiguration.LAUNCH_CONFIGURATION_FILE_EXTENSION.equals(file.getFileExtension()) || ILaunchConfiguration.LAUNCH_CONFIGURATION_PROTOTYPE_FILE_EXTENSION.equals(file.getFileExtension())) {
 					ILaunchConfiguration handle = new LaunchConfiguration(file);
 					switch (delta.getKind()) {
@@ -2199,8 +2198,7 @@ public void shutdown() {
 		for (ILaunch launch : getLaunches()) {
 			if(launch != null) {
 				try {
-					if (launch instanceof IDisconnect) {
-						IDisconnect disconnect = (IDisconnect)launch;
+					if (launch instanceof IDisconnect disconnect) {
 						if (disconnect.canDisconnect()) {
 							disconnect.disconnect();
 						}

debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/LogicalStructureType.java

@@ -135,8 +135,7 @@ protected ILogicalStructureTypeDelegate getDelegate() {
 	@Override
 	public String getDescription(IValue value) {
 		ILogicalStructureTypeDelegate delegate = getDelegate();
-		if (delegate instanceof ILogicalStructureTypeDelegate2) {
-			ILogicalStructureTypeDelegate2 d2 = (ILogicalStructureTypeDelegate2) delegate;
+		if (delegate instanceof ILogicalStructureTypeDelegate2 d2) {
 			return d2.getDescription(value);
 		}
 		if (!fVerifiedDescription) {

debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/XMLMemento.java

@@ -195,8 +195,7 @@ public XMLMemento getChild(String type) {
 		// Find the first node which is a child of this node.
 		for (int nX = 0; nX < size; nX++) {
 			Node node = nodes.item(nX);
-			if (node instanceof Element) {
-				Element element1 = (Element) node;
+			if (node instanceof Element element1) {
 				if (element1.getNodeName().equals(type)) {
 					return new XMLMemento(factory, element1);
 				}
@@ -223,8 +222,7 @@ public XMLMemento[] getChildren(String type) {
 		ArrayList<Element> list = new ArrayList<>(size);
 		for (int nX = 0; nX < size; nX++) {
 			Node node = nodes.item(nX);
-			if (node instanceof Element) {
-				Element element1 = (Element) node;
+			if (node instanceof Element element1) {
 				if (element1.getNodeName().equals(type)) {
 					list.add(element1);
 				}

debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/commands/StepFiltersCommand.java

@@ -52,14 +52,11 @@ protected Object getTarget(Object element) {
 	}
 
 	private IDebugTarget[] getDebugTargets(Object element) {
-		if (element instanceof IDebugElement) {
-			IDebugElement debugElement = (IDebugElement) element;
+		if (element instanceof IDebugElement debugElement) {
 			return new IDebugTarget[] { debugElement.getDebugTarget() };
-		} else if (element instanceof ILaunch) {
-			ILaunch launch = (ILaunch) element;
+		} else if (element instanceof ILaunch launch) {
 			return launch.getDebugTargets();
-		} else if (element instanceof IProcess) {
-			IProcess process = (IProcess) element;
+		} else if (element instanceof IProcess process) {
 			return process.getLaunch().getDebugTargets();
 		} else {
 			return new IDebugTarget[0];