Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Move CSS styles to own files #25

Open
JRIngram opened this issue Aug 26, 2021 · 3 comments
Open

Move CSS styles to own files #25

JRIngram opened this issue Aug 26, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers techdebt

Comments

@JRIngram
Copy link
Owner

Feature Request - Move CSS styles to own files

Describe the feature

Many components have CSS inside their .tsx file. These should be moved to their own .css files. e.g.
client/src/components/ColouredButton/ should contain:

  • ColouredButton.test.tsx
  • ColouredButton.tsx
  • ColouredButton.css
@JRIngram JRIngram added the enhancement New feature or request label Aug 26, 2021
@JRIngram JRIngram assigned JRIngram and unassigned JRIngram Aug 26, 2021
@JRIngram JRIngram added techdebt good first issue Good for newcomers labels Aug 26, 2021
@Jacoberson
Copy link
Contributor

I'd like to help with this as well.

@Jacoberson
Copy link
Contributor

Do you want this as .css file instead of a .style.js file? It looks like components are using React style props instead of actual CSS and would cause more refactoring than just moving the styles to their own file.

@JRIngram
Copy link
Owner Author

@Jacoberson ideally it would be great if we could have them as separate css files.

But so long as the styles are moved into separate files that should be fine. So I am happy with either style.js or css, depends how much refactoring you wish to do!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers techdebt
Projects
None yet
Development

No branches or pull requests

2 participants