Making sure apps reported by pm list packages are really apps

- due to some Xposed alterations, some libs throw warnings there,
  resulting in those being treated as apps
- other than originally assumed by reporter, this output goes to STDOUT
  (not STDERR), so additional filtering was required

Author: IzzySoft

adebar-cli

@@ -284,21 +284,27 @@ initAppLists() {
 
   doProgress "- userApps" 2
   for app in $(adb ${ADBOPTS} shell pm list packages -3 2>/dev/null); do
-    app=${app//[$'\t\r\n']} # remove trailing CR (^M)
-    userApps+=(${app##*:})
+    if [[ "${app}" =~ ^package: ]]; then
+      app=${app//[$'\t\r\n']} # remove trailing CR (^M)
+      userApps+=(${app##*:})
+    fi
   done
   doProgress "- systemApps" 2
   for app in $(adb ${ADBOPTS} shell pm list packages -s 2>/dev/null); do
-    app=${app//[$'\t\r\n']}
-    sysApps+=(${app##*:})
+    if [[ "${app}" =~ ^package: ]]; then
+      app=${app//[$'\t\r\n']}
+      sysApps+=(${app##*:})
+    fi
   done
   doProgress "- checking for uninstalled apps remembered by the system" 2
   for app in $(adb ${ADBOPTS} shell pm list packages -u 2>/dev/null); do
-    app=${app//[$'\t\r\n']}
-    in_array "${app##*:}" ${sysApps[@]} && continue
-    in_array "${app##*:}" ${userApps[@]} && continue
-    dApps+=($app)
-    echo "Removed app: ${app##*:}"
+    if [[ "${app}" =~ ^package: ]]; then
+      app=${app//[$'\t\r\n']}
+      in_array "${app##*:}" ${sysApps[@]} && continue
+      in_array "${app##*:}" ${userApps[@]} && continue
+      dApps+=($app)
+      echo "Found removed app entry: ${app##*:}"
+    fi
   done
 }
 

lib/scriptgen.lib

@@ -22,8 +22,10 @@ getDisabled() {
   echo >> "${scriptname}"
 
   for app in $(adb ${ADBOPTS} shell "pm list packages -d 2>/dev/null"); do
-    app=${app//[$'\t\r\n']}
-    echo "adb ${ADBOPTS} shell \"pm disable ${app##*:}\"" >> "${scriptname}"
+    if [[ "${app}" =~ ^package: ]]; then
+      app=${app//[$'\t\r\n']}
+      echo "adb ${ADBOPTS} shell \"pm disable ${app##*:}\"" >> "${scriptname}"
+    fi
   done
 
   chmod u+x "${scriptname}"