Skip to content

Commit b5ea762

Browse files
resolves merge conflicts
2 parents 7adcaea + cb26f25 commit b5ea762

File tree

9 files changed

+685
-697
lines changed

9 files changed

+685
-697
lines changed

CHANGELOG.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
1+
## 1.3.15
2+
## Updates
3+
- Resolves Android build issues caused in 1.3.14
4+
- Fixes a specific Android issue where custom action handlers were not invoked when tapping on push notification when the app is in background.
5+
6+
## 1.3.14
7+
> **Warning**
8+
> This version causes build failure on Android. Please use 1.3.15 which fixes this issue.
9+
## updates
10+
- updates `Iterable.setEmail` and `Iterable.setUserId` to take in null parameter type
11+
- fixes `Iterable.updateUser` on the Android side to merge nested objects in the user profile when `mergeNestedObjects` is set to true
12+
113
## 1.3.9
214
### Added
315

Iterable-React-Native-SDK.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,6 @@ Pod::Spec.new do |s|
2424

2525
s.swift_version = '5.3'
2626

27-
s.dependency 'Iterable-iOS-SDK', '~> 6.4.12'
27+
s.dependency 'Iterable-iOS-SDK', '~> 6.4.14'
2828
s.dependency 'React-Core'
2929
end

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ For quick reference, the following table lists the versions of the [Android SDK]
5858

5959
| RN SDK Version | Android SDK Version | iOS SDK Version |
6060
| --------------------------------------------------------------------------- | ---------------------------------------------------------------------------- | --------------- |
61+
| [1.3.15](https://www.npmjs.com/package/@iterable/react-native-sdk/v/1.3.15) | [3.4.14](https://github.com/Iterable/iterable-android-sdk/releases/tag/3.4.14) | [6.4.14](https://github.com/Iterable/swift-sdk/releases/tag/6.4.14)
62+
| [1.3.14](https://www.npmjs.com/package/@iterable/react-native-sdk/v/1.3.14) | [3.4.13](https://github.com/Iterable/iterable-android-sdk/releases/tag/3.4.13) | [6.4.14](https://github.com/Iterable/swift-sdk/releases/tag/6.4.14)
6163
| [1.3.13](https://www.npmjs.com/package/@iterable/react-native-sdk/v/1.3.13) | [3.4.11](https://github.com/Iterable/iterable-android-sdk/releases/tag/3.4.11) | [6.4.12](https://github.com/Iterable/swift-sdk/releases/tag/6.4.12)
6264
| [1.3.12](https://www.npmjs.com/package/@iterable/react-native-sdk/v/1.3.12) | [3.4.10](https://github.com/Iterable/iterable-android-sdk/releases/tag/3.4.10) | [6.4.12](https://github.com/Iterable/swift-sdk/releases/tag/6.4.12)
6365
| [1.3.11](https://www.npmjs.com/package/@iterable/react-native-sdk/v/1.3.11) | [3.4.10](https://github.com/Iterable/iterable-android-sdk/releases/tag/3.4.10) | [6.4.11](https://github.com/Iterable/swift-sdk/releases/tag/6.4.11)

android/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,6 @@ def getModuleVersion() {
2626

2727
dependencies {
2828
implementation 'com.facebook.react:react-native:+'
29-
//api 'com.iterable:iterableapi:3.4.11'
30-
api project(':iterableapi') // links to local android SDK repo rather than by release
29+
api 'com.iterable:iterableapi:3.4.14'
30+
// api project(':iterableapi') // links to local android SDK repo rather than by release
3131
}

android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ public void setUserId(@Nullable String userId, @Nullable String authToken) {
161161
@ReactMethod
162162
public void updateUser(ReadableMap dataFields, Boolean mergeNestedObjects) {
163163
IterableLogger.v(TAG, "updateUser");
164-
IterableApi.getInstance().updateUser(optSerializedDataFields(dataFields));
164+
IterableApi.getInstance().updateUser(optSerializedDataFields(dataFields), mergeNestedObjects);
165165
}
166166

167167
@ReactMethod

integration-testing/ios/example/ReactE2E.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ class ReactE2E: RCTEventEmitter {
8585
let campaignId = params["campaignId"] as! Int
8686
_ = IterableAPISupport.sendInApp(apiKey: apiKey, to: email, withCampaignId: campaignId)
8787
DispatchQueue.main.asyncAfter(deadline: .now() + 2.0) {
88-
_ = IterableAPI.internalImplementation?.inAppManager.scheduleSync()
88+
_ = IterableAPI.implementation?.inAppManager.scheduleSync()
8989
}
9090
break
9191
default:

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@iterable/react-native-sdk",
3-
"version": "1.3.13",
3+
"version": "1.3.15",
44
"description": "Iterable SDK for React Native.",
55
"main": "./js/index.js",
66
"types": "./js/index.d.ts",

ts/Iterable.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -209,11 +209,11 @@ class Iterable {
209209
*
210210
* Note: specify a user by calling Iterable.setEmail or Iterable.setUserId, but NOT both.
211211
*
212-
* @param {string | undefined} email email address to associate with the current user
213-
* @param {string | undefined} authToken valid, pre-fecthed JWT the SDK can use to authenticate API requests, optional - if null/undefined, no JWT related action will be taken
212+
* @param {string | null | undefined} email email address to associate with the current user
213+
* @param {string | null | undefined} authToken valid, pre-fetched JWT the SDK can use to authenticate API requests, optional - if null/undefined, no JWT related action will be taken
214214
*/
215215

216-
static setEmail(email: string | undefined, authToken?: string | undefined) {
216+
static setEmail(email?: string | null, authToken?: string | null) {
217217
Iterable.logger.log("setEmail: " + email)
218218

219219
RNIterableAPI.setEmail(email, authToken)
@@ -262,11 +262,11 @@ class Iterable {
262262
*
263263
* Note: specify a user by calling Iterable.setEmail or Iterable.setUserId, but NOT both.
264264
*
265-
* parameters: @param {string | undefined} userId user ID to associate with the current user
266-
* optional parameter: @param {string | undefined} authToken valid, pre-fecthed JWT the SDK can use to authenticate API requests, optional - if null/undefined, no JWT related action will be taken
265+
* parameters: @param {string | null | undefined} userId user ID to associate with the current user
266+
* optional parameter: @param {string | null | undefined} authToken valid, pre-fetched JWT the SDK can use to authenticate API requests, optional - if null/undefined, no JWT related action will be taken
267267
*/
268268

269-
static setUserId(userId: string | undefined, authToken?: string | undefined) {
269+
static setUserId(userId?: string | null, authToken?: string | null) {
270270
Iterable.logger.log("setUserId: " + userId)
271271

272272
RNIterableAPI.setUserId(userId, authToken)

0 commit comments

Comments
 (0)