Remove offline "beta" mentions from SDK.

Author: tapashmajumder

swift-sdk/Constants.swift

@@ -51,7 +51,6 @@ enum Const {
         static let deviceId = "itbl_device_id"
         static let sdkVersion = "itbl_sdk_version"
         static let offlineMode = "itbl_offline_mode"
-        static let offlineModeBeta = "itbl_offline_mode_beta"
 
         static let payloadExpiration = 24
         static let attributionInfoExpiration = 24

swift-sdk/Internal/InternalIterableAPI.swift

@@ -417,7 +417,7 @@ final class InternalIterableAPI: NSObject, PushTrackerProtocol, AuthProvider {
     }()
 
     lazy var requestHandler: RequestHandlerProtocol = {
-        let offlineMode = self.localStorage.isOfflineModeEnabled()
+        let offlineMode = self.localStorage.offlineMode
         return dependencyContainer.createRequestHandler(apiKey: apiKey,
                                                         config: config,
                                                         endPoint: apiEndPoint,
@@ -636,8 +636,7 @@ final class InternalIterableAPI: NSObject, PushTrackerProtocol, AuthProvider {
         ITBInfo()
         requestHandler.getRemoteConfiguration().onSuccess { remoteConfiguration in
             self.localStorage.offlineMode = remoteConfiguration.offlineMode
-            self.localStorage.offlineModeBeta = remoteConfiguration.offlineModeBeta
-            self.requestHandler.offlineMode = remoteConfiguration.isOfflineModeEnabled()
+            self.requestHandler.offlineMode = remoteConfiguration.offlineMode
             ITBInfo("setting offlineMode: \(self.requestHandler.offlineMode)")
         }.onError { error in
             let offlineMode = self.requestHandler.offlineMode

swift-sdk/Internal/IterableUserDefaults.swift

@@ -66,15 +66,6 @@ class IterableUserDefaults {
         }
     }
 
-    var offlineModeBeta: Bool {
-        get {
-            return bool(withKey: .offlineModeBeta)
-        }
-        set {
-            save(bool: newValue, withKey: .offlineModeBeta)
-        }
-    }
-    
     func getAttributionInfo(currentDate: Date) -> IterableAttributionInfo? {
         (try? codable(withKey: .attributionInfo, currentDate: currentDate)) ?? nil
     }
@@ -204,7 +195,6 @@ class IterableUserDefaults {
         static let deviceId = UserDefaultsKey(value: Const.UserDefault.deviceId)
         static let sdkVersion = UserDefaultsKey(value: Const.UserDefault.sdkVersion)
         static let offlineMode = UserDefaultsKey(value: Const.UserDefault.offlineMode)
-        static let offlineModeBeta = UserDefaultsKey(value: Const.UserDefault.offlineModeBeta)
     }
 
     private struct Envelope: Codable {

swift-sdk/Internal/LocalStorage.swift

@@ -67,15 +67,6 @@ struct LocalStorage: LocalStorageProtocol {
         }
     }
 
-    var offlineModeBeta: Bool {
-        get {
-            iterableUserDefaults.offlineModeBeta
-        }
-        set {
-            iterableUserDefaults.offlineModeBeta = newValue
-        }
-    }
-    
     func getAttributionInfo(currentDate: Date) -> IterableAttributionInfo? {
         iterableUserDefaults.getAttributionInfo(currentDate: currentDate)
     }

swift-sdk/Internal/LocalStorageProtocol.swift

@@ -12,7 +12,6 @@ protocol LocalStorageProtocol {
     var deviceId: String? { get set }
     var sdkVersion: String? { get set }
     var offlineMode: Bool { get set }
-    var offlineModeBeta: Bool { get set }
     func getAttributionInfo(currentDate: Date) -> IterableAttributionInfo?
     func save(attributionInfo: IterableAttributionInfo?, withExpiration expiration: Date?)
     func getPayload(currentDate: Date) -> [AnyHashable: Any]?
@@ -21,10 +20,6 @@ protocol LocalStorageProtocol {
 }
 
 extension LocalStorageProtocol {
-    func isOfflineModeEnabled() -> Bool {
-        RemoteConfiguration.isBeta ? offlineModeBeta  : offlineMode
-    }
-
     func upgrade() {
     }
 }

swift-sdk/Internal/Models.swift

@@ -6,13 +6,5 @@
 import Foundation
 
 struct RemoteConfiguration: Codable, Equatable {
-    static let isBeta = false
-    
     let offlineMode: Bool
-    let offlineModeBeta: Bool
-    
-    func isOfflineModeEnabled() -> Bool {
-        Self.isBeta ? offlineModeBeta : offlineMode
-    }
-    
 }

tests/common/CommonMocks.swift

@@ -434,8 +434,6 @@ class MockLocalStorage: LocalStorageProtocol {
 
     var offlineMode: Bool = false
 
-    var offlineModeBeta: Bool = false
-    
     func getAttributionInfo(currentDate: Date) -> IterableAttributionInfo? {
         guard !MockLocalStorage.isExpired(expiration: attributionInfoExpiration, currentDate: currentDate) else {
             return nil

tests/offline-events-tests/RequestHandlerTests.swift

@@ -688,7 +688,7 @@ class RequestHandlerTests: XCTestCase {
 
     func testGetRemoteConfiguration() throws {
         let expectation1 = expectation(description: #function)
-        let expectedRemoteConfiguration = RemoteConfiguration(offlineMode: true, offlineModeBeta: true)
+        let expectedRemoteConfiguration = RemoteConfiguration(offlineMode: true)
         let data = try JSONEncoder().encode(expectedRemoteConfiguration)
         let notificationCenter = MockNotificationCenter()
         let networkSession = MockNetworkSession(statusCode: 200, data: data)

tests/unit-tests/LocalStorageTests.swift

@@ -169,19 +169,6 @@ class LocalStorageTests: XCTestCase {
         testLocalStorage(saver: saver, retriever: retriever, value: false)
     }
 
-    func testOfflineModeBeta() {
-        let saver = { (storage: LocalStorageProtocol, value: Bool) -> Void in
-            var localStorage = storage
-            localStorage.offlineModeBeta = value
-        }
-        let retriever = { (storage: LocalStorageProtocol) -> Bool? in
-            storage.offlineModeBeta
-        }
-        
-        testLocalStorage(saver: saver, retriever: retriever, value: true)
-        testLocalStorage(saver: saver, retriever: retriever, value: false)
-    }
-    
     private func testLocalStorage<T>(saver: (LocalStorageProtocol, T) -> Void,
                                      retriever: (LocalStorageProtocol) -> T?, value: T) where T: Equatable {
         let localStorage = LocalStorage(userDefaults: LocalStorageTests.getTestUserDefaults())