Merge pull request #457 from Iterable/tapash/mob-2206-remove-fatalerror

[MOB-2206] - Remove fatalerror

Author: tapashmajumder

swift-sdk/Internal/CoreDataUtil.swift

@@ -62,7 +62,8 @@ struct CoreDataUtil {
         } else if let boolValue = columnValue as? Bool {
             return NSPredicate(format: "%K == %@", columnName, NSNumber(value: boolValue))
         } else {
-            fatalError("unsuppored value: \(columnValue)")
+            ITBError("unsuppored value: \(columnValue) for columnPredicate")
+            return NSPredicate()
         }
     }
 }

swift-sdk/Internal/IterableCoreDataPersistence.swift

@@ -38,7 +38,7 @@ class PersistentContainer: NSPersistentContainer {
         let container = PersistentContainer(name: PersistenceConst.dataModelFileName, managedObjectModel: managedObjectModel)
         container.loadPersistentStores { desc, error in
             if let error = error {
-                fatalError("Unresolved error \(error)")
+                ITBError("Unresolved error when creating PersistentContainer: \(error)")
             }
 
             ITBInfo("Successfully loaded persistent store at: \(desc.url?.description ?? "nil")")

swift-sdk/Internal/OfflineRequestProcessor.swift

@@ -268,7 +268,7 @@ struct OfflineRequestProcessor: RequestProcessorProtocol {
                                      failureHandler onFailure: OnFailureHandler?,
                                      identifier: String) -> Future<SendRequestValue, SendRequestError> {
         guard let authProvider = authProvider else {
-            fatalError("authProvider is missing")
+            return SendRequestError.createErroredFuture(reason: "AuthProvider is missing")
         }
 
         let requestCreator = createRequestCreator(authProvider: authProvider)

swift-sdk/IterableInboxViewController.swift

@@ -532,7 +532,8 @@ private struct CellLoader {
                 let nib = UINib(nibName: cellNibName, bundle: Bundle.main)
                 tableView.register(nib, forCellReuseIdentifier: defaultCellReuseIdentifier)
             } else {
-                fatalError("Cannot find nib: \(cellNibName) in main bundle.")
+                ITBError("Cannot find nib: \(cellNibName) in main bundle. Using default.")
+                tableView.register(IterableInboxCell.self, forCellReuseIdentifier: defaultCellReuseIdentifier)
             }
         } else {
             tableView.register(IterableInboxCell.self, forCellReuseIdentifier: defaultCellReuseIdentifier)