Skip to content

Commit 4b711be

Browse files
AyyanchiraAyyanchira
authored
Merge pull request #846 from Iterable/MOB-9101-EM-Button-Cut-Fix
[MOB-9101] - EM OOTB Button Text Crop Fix
2 parents f54e812 + 94262e0 commit 4b711be

File tree

6 files changed

+25
-21
lines changed

6 files changed

+25
-21
lines changed

‎iterableapi-ui/src/main/res/layout-v21/banner_view.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@
7474
android:ellipsize="end"
7575
android:layout_marginStart="16dp"
7676
android:layout_marginEnd="8dp"
77-
android:paddingTop="8dp"
78-
android:paddingBottom="8dp"
77+
android:paddingTop="0dp"
78+
android:paddingBottom="0dp"
7979
android:paddingStart="12dp"
8080
android:paddingEnd="12dp"
8181
android:singleLine="true"
@@ -91,8 +91,8 @@
9191
android:layout_height="36dp"
9292
android:background="@drawable/secondary_banner_button_background"
9393
android:ellipsize="end"
94-
android:paddingTop="8dp"
95-
android:paddingBottom="8dp"
94+
android:paddingTop="0dp"
95+
android:paddingBottom="0dp"
9696
android:paddingStart="12dp"
9797
android:paddingEnd="12dp"
9898
android:singleLine="true"

‎iterableapi-ui/src/main/res/layout-v21/card_view.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@
8585
android:ellipsize="end"
8686
android:layout_marginStart="16dp"
8787
android:layout_marginEnd="8dp"
88-
android:paddingTop="8dp"
89-
android:paddingBottom="8dp"
88+
android:paddingTop="0dp"
89+
android:paddingBottom="0dp"
9090
android:paddingStart="12dp"
9191
android:paddingEnd="12dp"
9292
android:singleLine="true"
@@ -102,8 +102,8 @@
102102
android:layout_height="36dp"
103103
android:background="@drawable/secondary_card_button_background"
104104
android:ellipsize="end"
105-
android:paddingTop="8dp"
106-
android:paddingBottom="8dp"
105+
android:paddingTop="0dp"
106+
android:paddingBottom="0dp"
107107
android:paddingStart="12dp"
108108
android:paddingEnd="12dp"
109109
android:singleLine="true"

‎iterableapi-ui/src/main/res/layout-v21/notification_view.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@
6767
android:textColor="@color/notification_text_color"
6868
android:background="@drawable/primary_notification_button_background"
6969
android:ellipsize="end"
70-
android:paddingTop="8dp"
71-
android:paddingBottom="8dp"
70+
android:paddingTop="0dp"
71+
android:paddingBottom="0dp"
7272
android:paddingStart="12dp"
7373
android:paddingEnd="12dp"
7474
android:singleLine="true"
@@ -84,8 +84,8 @@
8484
android:textColor="@color/notification_text_color"
8585
android:background="@drawable/secondary_notification_button_background"
8686
android:ellipsize="end"
87-
android:paddingTop="8dp"
88-
android:paddingBottom="8dp"
87+
android:paddingTop="0dp"
88+
android:paddingBottom="0dp"
8989
android:paddingStart="12dp"
9090
android:paddingEnd="12dp"
9191
android:singleLine="true"

‎iterableapi-ui/src/main/res/layout/banner_view.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@
7272
android:background="@drawable/primary_banner_button_background"
7373
android:ellipsize="end"
7474
android:layout_marginStart="16dp"
75-
android:paddingTop="8dp"
76-
android:paddingBottom="8dp"
75+
android:paddingTop="0dp"
76+
android:paddingBottom="0dp"
7777
android:paddingStart="12dp"
7878
android:paddingEnd="12dp"
7979
android:singleLine="true"
@@ -90,8 +90,8 @@
9090
android:layout_marginEnd="16dp"
9191
android:background="@drawable/secondary_banner_button_background"
9292
android:ellipsize="end"
93-
android:paddingTop="8dp"
94-
android:paddingBottom="8dp"
93+
android:paddingTop="0dp"
94+
android:paddingBottom="0dp"
9595
android:paddingStart="12dp"
9696
android:paddingEnd="12dp"
9797
android:singleLine="true"

‎iterableapi-ui/src/main/res/layout/card_view.xml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,14 +78,16 @@
7878

7979
<Button
8080
android:id="@+id/embedded_message_first_button"
81-
android:layout_width="0dp"
81+
android:layout_width="wrap_content"
8282
android:layout_height="36dp"
8383
android:layout_marginStart="16dp"
8484
android:layout_marginEnd="8dp"
8585
android:background="@drawable/primary_card_button_background"
8686
android:ellipsize="end"
8787
android:paddingStart="8dp"
8888
android:paddingEnd="8dp"
89+
android:paddingTop="0dp"
90+
android:paddingBottom="0dp"
8991
android:singleLine="true"
9092
android:stateListAnimator="@null"
9193
android:textAllCaps="false"
@@ -97,6 +99,8 @@
9799
android:layout_width="0dp"
98100
android:layout_height="36dp"
99101
android:layout_marginEnd="16dp"
102+
android:paddingTop="0dp"
103+
android:paddingBottom="0dp"
100104
android:layout_weight="1"
101105
android:background="@drawable/secondary_card_button_background"
102106
android:ellipsize="end"

‎iterableapi-ui/src/main/res/layout/notification_view.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@
6565
android:textColor="@color/notification_text_color"
6666
android:background="@drawable/primary_notification_button_background"
6767
android:ellipsize="end"
68-
android:paddingTop="8dp"
69-
android:paddingBottom="8dp"
68+
android:paddingTop="0dp"
69+
android:paddingBottom="0dp"
7070
android:paddingStart="12dp"
7171
android:paddingEnd="12dp"
7272
android:singleLine="true"
@@ -83,8 +83,8 @@
8383
android:textColor="@color/notification_text_color"
8484
android:background="@drawable/secondary_notification_button_background"
8585
android:ellipsize="end"
86-
android:paddingTop="8dp"
87-
android:paddingBottom="8dp"
86+
android:paddingTop="0dp"
87+
android:paddingBottom="0dp"
8888
android:paddingStart="12dp"
8989
android:paddingEnd="12dp"
9090
android:singleLine="true"

0 commit comments

Comments
 (0)