Skip to content

Commit 2babb82

Browse files
committed
refactor(config)!: delete complete configs
1 parent 507ead2 commit 2babb82

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+26803
-22937
lines changed

.github/workflows/setup/action.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,12 @@ runs:
22
using: composite
33

44
steps:
5-
# TODO: Remove this section once `setup-node` has a corepack option:
6-
# https://github.com/actions/setup-node/pull/901
7-
- name: Enable corepack to work around a setup-node bug
8-
run: corepack enable
9-
shell: bash # Composite jobs must specify the shell.
10-
115
- name: Setup Node.js
126
uses: actions/setup-node@v4
137
with:
148
node-version: lts/*
15-
cache: yarn
9+
cache: npm
1610

1711
- name: Install dependencies
18-
run: yarn install --immutable
12+
run: npm ci
1913
shell: bash # Composite jobs must specify the shell.

README.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,8 @@ For getting started in building your own mods, see the [website](https://isaacsc
5656
(replace "[username]" with your GitHub username)
5757
- Enter the cloned repository:
5858
- `cd isaacscript`
59-
- Ensure that [Yarn](https://classic.yarnpkg.com/lang/en/) is installed:
60-
- `corepack enable`
6159
- Install dependencies:
62-
- `yarn install`
60+
- `npm ci`
6361
- Open the monorepo in VSCode:
6462
- `code .`
6563

@@ -81,6 +79,6 @@ This command will initialize a new mod named "test" and then automatically link
8179

8280
### Using an Existing Mod
8381

84-
Testing with a brand new mod is recommended, but it is also possible to use an existing mod. Just set `"isaacScriptCommonDev": true` in your `isaacscript.json` file and then start IsaacScript. (Doing this will automatically set up the local Yarn link.)
82+
Testing with a brand new mod is recommended, but it is also possible to use an existing mod. Just set `"isaacScriptCommonDev": true` in your `isaacscript.json` file and then start IsaacScript. (Doing this will automatically set up the local npm link.)
8583

86-
Make sure that your existing mod project uses Yarn as the package manager, or the link won't work properly.
84+
Make sure that your existing mod project uses npm as the package manager, or the link won't work properly.

cspell.jsonc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,7 @@
3737
// @template-customization-end
3838
],
3939
"words": [
40-
"adduser",
4140
"APPDATA",
42-
"arktype",
4341
"Basarat",
4442
"celsiusnarhwal",
4543
"chunkname",
@@ -53,7 +51,6 @@
5351
"nonblock",
5452
"nonconstructor",
5553
"nonoctal",
56-
"preid",
5754
"pypi",
5855
"pyproject",
5956
"remarkrc",

eslint.config.mjs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
import { base } from "./packages/eslint-config-isaacscript/base.js";
2-
import { monorepo } from "./packages/eslint-config-isaacscript/monorepo.js";
1+
// @ts-check
32

4-
export default [...base, ...monorepo];
3+
import {
4+
completeConfigBase,
5+
completeConfigMonorepo,
6+
} from "eslint-config-complete";
7+
8+
export default [...completeConfigBase, ...completeConfigMonorepo];
Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
1-
{
2-
"$schema": "https://unpkg.com/knip@3/schema-jsonc.json",
3-
"workspaces": {
1+
// This is the configuration file for Knip:
2+
// https://knip.dev/overview/configuration
3+
4+
// @ts-check
5+
6+
/** @type {import("knip").KnipConfig} */
7+
const config = {
8+
workspaces: {
9+
"packages/*": {},
410
"packages/docs": {
5-
"ignore": [
11+
ignore: [
612
"babel.config.js",
713
"docusaurus.config.ts",
814
"scripts/**",
@@ -13,43 +19,45 @@
1319
],
1420
},
1521
"packages/eslint-config-isaacscript": {
16-
"entry": ["base.js", "mod.js"],
22+
entry: ["base.js", "mod.js"],
1723
},
1824
"packages/eslint-plugin-isaacscript": {
19-
"ignore": [
25+
ignore: [
2026
"src/template.ts",
2127
"tests/fixtures/file.ts",
2228
"tests/template.ts",
2329
],
2430
},
2531
"packages/isaac-lua-polyfill": {},
2632
"packages/isaac-typescript-definitions": {
27-
"ignore": ["typedoc.config.mjs"],
33+
ignore: ["typedoc.config.mjs"],
2834
},
2935
"packages/isaac-typescript-definitions-repentogon": {
30-
"ignore": ["typedoc.config.mjs"],
36+
ignore: ["typedoc.config.mjs"],
3137
},
3238
"packages/isaacscript-cli": {
33-
"entry": [
39+
entry: [
3440
"src/main.ts",
3541
"src/commands/monitor/modDirectorySyncer/modDirectorySyncer.ts",
3642
"src/commands/monitor/saveDatWriter/saveDatWriter.ts",
3743
],
38-
"ignore": [
44+
ignore: [
3945
"**/copied/**",
4046
"file-templates/**",
4147
"plugins/**",
4248
"src/interfaces/IsaacScriptTSConfig.ts",
4349
],
4450
},
4551
"packages/isaacscript-common": {
46-
"ignore": [
52+
ignore: [
4753
"src/classes/features/other/extraConsoleCommands/commands.ts",
4854
"src/lib/jsonLua.js",
4955
"typedoc.config.mjs",
5056
],
5157
},
5258
"packages/isaacscript-spell": {},
5359
},
54-
"ignoreDependencies": ["eslint-plugin-isaacscript"],
55-
}
60+
ignoreDependencies: ["eslint-plugin-isaacscript"],
61+
};
62+
63+
export default config;

0 commit comments

Comments
 (0)