Skip to content

Commit

Permalink
refactor(config)!: delete complete configs
Browse files Browse the repository at this point in the history
  • Loading branch information
Zamiell committed Sep 11, 2024
1 parent 507ead2 commit 2babb82
Show file tree
Hide file tree
Showing 52 changed files with 26,803 additions and 22,937 deletions.
10 changes: 2 additions & 8 deletions .github/workflows/setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,12 @@ runs:
using: composite

steps:
# TODO: Remove this section once `setup-node` has a corepack option:
# https://github.com/actions/setup-node/pull/901
- name: Enable corepack to work around a setup-node bug
run: corepack enable
shell: bash # Composite jobs must specify the shell.

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: lts/*
cache: yarn
cache: npm

- name: Install dependencies
run: yarn install --immutable
run: npm ci
shell: bash # Composite jobs must specify the shell.
8 changes: 3 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,8 @@ For getting started in building your own mods, see the [website](https://isaacsc
(replace "[username]" with your GitHub username)
- Enter the cloned repository:
- `cd isaacscript`
- Ensure that [Yarn](https://classic.yarnpkg.com/lang/en/) is installed:
- `corepack enable`
- Install dependencies:
- `yarn install`
- `npm ci`
- Open the monorepo in VSCode:
- `code .`

Expand All @@ -81,6 +79,6 @@ This command will initialize a new mod named "test" and then automatically link

### Using an Existing Mod

Testing with a brand new mod is recommended, but it is also possible to use an existing mod. Just set `"isaacScriptCommonDev": true` in your `isaacscript.json` file and then start IsaacScript. (Doing this will automatically set up the local Yarn link.)
Testing with a brand new mod is recommended, but it is also possible to use an existing mod. Just set `"isaacScriptCommonDev": true` in your `isaacscript.json` file and then start IsaacScript. (Doing this will automatically set up the local npm link.)

Make sure that your existing mod project uses Yarn as the package manager, or the link won't work properly.
Make sure that your existing mod project uses npm as the package manager, or the link won't work properly.
3 changes: 0 additions & 3 deletions cspell.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,7 @@
// @template-customization-end
],
"words": [
"adduser",
"APPDATA",
"arktype",
"Basarat",
"celsiusnarhwal",
"chunkname",
Expand All @@ -53,7 +51,6 @@
"nonblock",
"nonconstructor",
"nonoctal",
"preid",
"pypi",
"pyproject",
"remarkrc",
Expand Down
10 changes: 7 additions & 3 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
import { base } from "./packages/eslint-config-isaacscript/base.js";
import { monorepo } from "./packages/eslint-config-isaacscript/monorepo.js";
// @ts-check

export default [...base, ...monorepo];
import {
completeConfigBase,
completeConfigMonorepo,
} from "eslint-config-complete";

export default [...completeConfigBase, ...completeConfigMonorepo];
34 changes: 21 additions & 13 deletions knip.jsonc → knip.config.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
{
"$schema": "https://unpkg.com/knip@3/schema-jsonc.json",
"workspaces": {
// This is the configuration file for Knip:
// https://knip.dev/overview/configuration

// @ts-check

/** @type {import("knip").KnipConfig} */
const config = {
workspaces: {
"packages/*": {},
"packages/docs": {
"ignore": [
ignore: [
"babel.config.js",
"docusaurus.config.ts",
"scripts/**",
Expand All @@ -13,43 +19,45 @@
],
},
"packages/eslint-config-isaacscript": {
"entry": ["base.js", "mod.js"],
entry: ["base.js", "mod.js"],
},
"packages/eslint-plugin-isaacscript": {
"ignore": [
ignore: [
"src/template.ts",
"tests/fixtures/file.ts",
"tests/template.ts",
],
},
"packages/isaac-lua-polyfill": {},
"packages/isaac-typescript-definitions": {
"ignore": ["typedoc.config.mjs"],
ignore: ["typedoc.config.mjs"],
},
"packages/isaac-typescript-definitions-repentogon": {
"ignore": ["typedoc.config.mjs"],
ignore: ["typedoc.config.mjs"],
},
"packages/isaacscript-cli": {
"entry": [
entry: [
"src/main.ts",
"src/commands/monitor/modDirectorySyncer/modDirectorySyncer.ts",
"src/commands/monitor/saveDatWriter/saveDatWriter.ts",
],
"ignore": [
ignore: [
"**/copied/**",
"file-templates/**",
"plugins/**",
"src/interfaces/IsaacScriptTSConfig.ts",
],
},
"packages/isaacscript-common": {
"ignore": [
ignore: [
"src/classes/features/other/extraConsoleCommands/commands.ts",
"src/lib/jsonLua.js",
"typedoc.config.mjs",
],
},
"packages/isaacscript-spell": {},
},
"ignoreDependencies": ["eslint-plugin-isaacscript"],
}
ignoreDependencies: ["eslint-plugin-isaacscript"],
};

export default config;
Loading

0 comments on commit 2babb82

Please sign in to comment.