add option to perform a credit card extra validation #39

Author: hugomaiavieira

README.md

@@ -132,14 +132,24 @@ credit_card = MyMoip::CreditCard.new(
   owner_name:      'Juquinha da Rocha',
   owner_birthday:  '03/11/1984',
   owner_phone:     '5130405060',
-  owner_cpf:       '52211670695'
+  owner_cpf:       '52211670695',
+  perform_extra_validation: true  # optional: see the next sub section
 )
 
 credit_card_payment = MyMoip::CreditCardPayment.new(credit_card, installments: 1)
 payment_request = MyMoip::PaymentRequest.new('your_logging_id')
 payment_request.api_call(credit_card_payment, token: transparent_request.token)
 ```
 
+##### Credit card extra validation
+
+There is a already [reported](http://goo.gl/celJIZ) bug that the API don't
+requires some attributes returning a successful
+[response](https://gist.github.com/Irio/4032350). To "fix it" you can enable an
+extra validation with `perform_extra_validation` option. It will require the
+presence of all credit card attributes.
+
+
 #### Payment slip (aka boleto)
 
 ```ruby

lib/mymoip/credit_card.rb

@@ -3,7 +3,8 @@ class CreditCard
     include ActiveModel::Validations
 
     attr_accessor :logo, :card_number, :expiration_date, :security_code,
-                :owner_name, :owner_birthday, :owner_phone, :owner_cpf
+                  :owner_name, :owner_birthday, :owner_phone, :owner_cpf,
+                  :perform_extra_validation
 
     AVAILABLE_LOGOS = [
       :american_express, :diners, :hipercard, :mastercard, :visa
@@ -15,6 +16,10 @@ class CreditCard
     validates_format_of :expiration_date, with: /\A(?:(?:0[1-9])|(?:1[0-2]))\/\d{2}\Z/ # %m/%y
     validates_inclusion_of :logo, in: AVAILABLE_LOGOS
     validate :owner_birthday_format
+    validates_presence_of :card_number, :expiration_date, :owner_name,
+                          :owner_phone, :owner_cpf,
+                          if: ->(resource) { resource.perform_extra_validation }
+
 
     def initialize(attrs)
       attrs.each do |attr, value|

test/lib/test_creditcard.rb

@@ -10,7 +10,8 @@ def test_initialization_and_setters
       owner_name: "Juquinha da Rocha",
       owner_birthday: Date.new(1984, 11, 3),
       owner_phone: "5130405060",
-      owner_cpf: "522.116.706-95"
+      owner_cpf: "522.116.706-95",
+      perform_extra_validation: true
     )
 
     assert_equal :visa, subject.logo
@@ -21,18 +22,20 @@ def test_initialization_and_setters
     assert_equal Date.new(1984, 11, 3), subject.owner_birthday
     assert_equal "5130405060", subject.owner_phone
     assert_equal "52211670695", subject.owner_cpf
+    assert_equal true, subject.perform_extra_validation
   end
 
   def test_initialization_and_setters_with_string_keys
     subject = MyMoip::CreditCard.new(
-      'logo'            => :visa,
-      'card_number'     => '4916654211627608',
-      'expiration_date' => '06/15',
-      'security_code'   => '000',
-      'owner_name'      => 'Juquinha da Rocha',
-      'owner_birthday'  => Date.new(1984, 11, 3),
-      'owner_phone'     => '5130405060',
-      'owner_cpf'       => '522.116.706-95'
+      'logo'                     => :visa,
+      'card_number'              => '4916654211627608',
+      'expiration_date'          => '06/15',
+      'security_code'            => '000',
+      'owner_name'               => 'Juquinha da Rocha',
+      'owner_birthday'           => Date.new(1984, 11, 3),
+      'owner_phone'              => '5130405060',
+      'owner_cpf'                => '522.116.706-95',
+      'perform_extra_validation' => false
     )
 
     assert_equal :visa, subject.logo
@@ -43,6 +46,7 @@ def test_initialization_and_setters_with_string_keys
     assert_equal Date.new(1984, 11, 3), subject.owner_birthday
     assert_equal "5130405060", subject.owner_phone
     assert_equal "52211670695", subject.owner_cpf
+    assert_equal false, subject.perform_extra_validation
   end
 
   def test_validate_presence_of_logo_attribute
@@ -94,6 +98,23 @@ def test_validate_length_of_owner_phone_attribute_in_10_or_11_chars
       'should not accept strings with other than 10 or 11 chars'
   end
 
+  def test_perform_extra_validation
+    subject = Fixture.credit_card({
+      card_number: nil,
+      expiration_date: nil,
+      owner_name: nil,
+      owner_phone: nil,
+      owner_cpf: nil,
+      perform_extra_validation: true
+    })
+    assert subject.invalid?
+    assert subject.errors[:card_number],      "can't be blank"
+    assert subject.errors[:expiration_date],  "can't be blank"
+    assert subject.errors[:owner_name],       "can't be blank"
+    assert subject.errors[:owner_phone],      "can't be blank"
+    assert subject.errors[:owner_cpf],        "can't be blank"
+  end
+
   def test_remove_left_zeros_from_owner_phone
     subject = Fixture.credit_card
     subject.owner_phone = '05130405060'