Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in a table (+ new project for the list) #80

Open
tpronk opened this issue Mar 3, 2021 · 3 comments
Open

Links in a table (+ new project for the list) #80

tpronk opened this issue Mar 3, 2021 · 3 comments
Labels

Comments

@tpronk
Copy link

tpronk commented Mar 3, 2021

Hey, thanks for writing this module! I'm using it to tabulate unit and e2e that will end up in this wiki: https://github.com/tpronk/e2e_robot/wiki/Overview-of-WebdriverIO-tests, which we'll later integrate into PsychoJS: https://github.com/psychopy/psychojs

I noticed a little issue when using links in table cells: a newline character is added at the end of the link, but this confuses the table; it assumes a new row is started after the link.

@IonicaBizau
Copy link
Owner

Good catch! I don't have time to solve this currently but contributions are welcome! ❇️

@tpronk
Copy link
Author

tpronk commented Apr 16, 2021

Sure! I'm a bit hesitant though, since removing newlines after elements like links etc, would change the output in ways other users wouldn't expect. Maybe on the list for any future major version update?

@konhi
Copy link

konhi commented Aug 28, 2021

Removing \n from line 71 fixes the issue (but may create other problems). Since I don't think this repository is actively maintained, I won't work on this issue yet (but let me know if this change!). Best option may be doing nested json2md function and then trim() it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants