Updates code to match new SwiftLint requirements

Changes include:
1. Relax identifier_name warning criteria
- Many functions in this pod use the ip_functionName naming scheme,
so we should allow underscores.
- Many library functions use r, g, b, x, y as identifiers. Permit it.
- Finally, there are enough existing two character identifiers that we
should simply allow them.

2. Cleanup remaining identifier_name warnings

3. Replace class with AnyObject in protocols

4. Fix method access levels

5. Disable several warnings locally (in-file), including:
- function_default_parameter_at_end
- type_name
- static_operator
- nslocalizedstring_key
Some public methods violate these rules. We're not going to change the
public API for those, so deactivate those warnings at specific sites.

6. Mark unavailable methods as such

7. Replace arc4random_uniform with random
In Swift 4.2, arc4random_uniform(:) is replaced by Int.random(in:)
When rewriting our random(inRange:) function to account for that, I
realized that random(inRange:) is IDENTICAL to Int.random(in:).
So I deprecated random(inRange:) in favor of Int.random(in:)

Author: bobgilmore

.swiftlint.yml

@@ -198,8 +198,16 @@ file_length:
   error: 1500
 
 identifier_name:
+  allowed_symbols: "_"
+  min_length: 2
   excluded:
     - id
+    - r
+    - g
+    - b
+    - a
+    - x
+    - y
 
 lower_acl_than_parent:
   severity: error

SwiftWisdom/AppDelegate.swift

@@ -13,7 +13,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
 
     var window: UIWindow?
 
-    public func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil) -> Bool {
+    func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil) -> Bool {
         // Override point for customization after application launch.
         return true
     }

SwiftWisdom/Core/Async/Qu/Qu.swift

@@ -16,7 +16,9 @@ public typealias CompletableBlock = (@escaping Block) -> ()
 
 // MARK: Qu
 
+//swiftlint:disable type_name
 public class Qu {
+//swiftlint:enable type_name
 
     // MARK: Priority Enumeration
 

SwiftWisdom/Core/CommonTypes/Multicast.swift

@@ -25,7 +25,7 @@ public struct Weak<T> where T: AnyObject {
     Only subclasses of NSObject can conform to this protocol. In addition, you can only typealias `MulticastDelegate` to a
     class or an `@objc` protocol.
  */
-public protocol Multicast: class {
+public protocol Multicast: AnyObject {
 
     associatedtype MulticastDelegate: AnyObject
 

SwiftWisdom/Core/Controls/VideoPlayer.swift

@@ -69,7 +69,7 @@ extension Video {
 
 // MARK: Player
 
-public protocol VideoPlayerDelegate: class {
+public protocol VideoPlayerDelegate: AnyObject {
     /**
      The delegate is notified when the video finishes playing and returns 
      a boolean whether or not the video should repeat
@@ -109,6 +109,7 @@ public final class VideoPlayer: UIViewController {
         setupItemNotification(item)
     }
 
+    @available(*, unavailable)
     public required init?(coder aDecoder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }

SwiftWisdom/Core/DirectoryManager/DirectoryManager.swift

@@ -59,6 +59,7 @@ public final class DirectoryManager {
         return ((try? data.write(to: URL(fileURLWithPath: path), options: [.atomicWrite])) != nil)
     }
 
+    //swiftlint:disable function_default_parameter_at_end
     public func writeInBackground(_ data: Data, withName name: String = UUID().uuidString, completion: @escaping (String, Bool) -> Void = { _, _  in }) {
         Background {
             let success = self.write(data, withName: name)
@@ -67,6 +68,7 @@ public final class DirectoryManager {
             }
         }
     }
+    //swiftlint:enable function_default_parameter_at_end
 
     // MARK: Delete
 

SwiftWisdom/Core/Foundation/Data/Data+Extensions.swift

@@ -141,6 +141,7 @@ extension Data {
 }
 
 extension Data {
+    //swiftlint:disable function_default_parameter_at_end
     public func ip_segmentIterator(start: Int = 0, chunkLength: Int) -> AnyIterator<Data> {
         var iteratedData = ip_suffix(from: start)
         return AnyIterator {
@@ -157,4 +158,5 @@ extension Data {
             return nextData
         }
     }
+    //swiftlint:enable function_default_parameter_at_end
 }

SwiftWisdom/Core/Foundation/Not.swift

@@ -11,6 +11,9 @@
 
       let newNames = ["Joe", "Betty"].filter(!existingNames.contains)
  */
+
+//swiftlint:disable static_operator
 public prefix func ! <T>(original: @escaping (T) -> Bool) -> (T) -> Bool {
     return { !original($0) }
 }
+//swiftlint:enable static_operator

SwiftWisdom/Core/StandardLibrary/Array/Sequence+Utilities.swift

@@ -79,7 +79,7 @@ extension Sequence where Iterator.Element: Equatable {
     ///
     /// - returns: `true` if the sequence contains `all`
     public func ip_contains<T: Sequence>(all: T) -> Bool where T.Iterator.Element == Iterator.Element {
-        for e in all where !contains(e) {
+        for element in all where !contains(element) {
             return false
         }
         return true

SwiftWisdom/Core/StandardLibrary/Numbers/UnsignedInteger+Extensions.swift

@@ -11,17 +11,14 @@ import Foundation
 extension UnsignedInteger {
     public static func ip_random() -> Self {
         let intMax = Int(Int64(ip_maxValue))
-        let rand = random(inRange: 0...intMax)
+        let rand = Int.random(in: 0...intMax)
         return self.init(ip_safely: rand)
     }
 }
 
-// TODO: evaluate whether we should move random to be a member of CountableClosedRange
+@available(*, deprecated, message: "Use Int.random(in:) instead", renamed: "Int.random(in:)")
 public func random(inRange range: CountableClosedRange<Int>) -> Int {
-    let diff = range.upperBound - range.lowerBound
-    let randomOffset = Int(arc4random_uniform(UInt32(diff + 1)))
-    let random = range.lowerBound + randomOffset
-    return random
+    return Int.random(in: range)
 }
 
 // TODO: write tests for this extension

SwiftWisdom/Core/StandardLibrary/String/String+Data.swift

@@ -17,8 +17,8 @@ extension String {
 
         var data = Data(capacity: trimmed.count / 2)
 
-        for i in stride(from: 0, through: trimmed.count - 2, by: 2) {
-            let byteString = trimmed[i...i + 1]
+        for step in stride(from: 0, through: trimmed.count - 2, by: 2) {
+            let byteString = trimmed[step...step + 1]
             var byte = UInt8(byteString.ip_hexInt)
             data.append(&byte, count: MemoryLayout<UInt8>.size)
         }

SwiftWisdom/Core/StandardLibrary/String/String+Localization.swift

@@ -2,7 +2,9 @@ import Foundation
 
 extension String {
     public func ip_localized(_ args: [CVarArg] = [], comment: String = "") -> String {
+        //swiftlint:disable nslocalizedstring_key
         let localizedFormat = NSLocalizedString(self, comment: comment)
+        //swiftlint:enable nslocalizedstring_key
         return String(format: localizedFormat, arguments: args)
     }
 }

SwiftWisdom/Core/UIKit/CoreAnimation/BasicVerticalGradientLayer.swift

@@ -18,6 +18,7 @@ public final class BasicVerticalGradientLayer: CAGradientLayer {
         colors = [topColor.cgColor, bottomColor.cgColor]
     }
 
+    @available(*, unavailable)
     required public init(coder aDecoder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }

SwiftWisdom/Core/UIKit/PercentAnimator/PercentAnimator.swift

@@ -52,7 +52,7 @@ private final class PercentAnimator {
 
     private static let shared = PercentAnimator()
 
-    static func animateWithDuration(
+    fileprivate static func animateWithDuration(
         _ duration: TimeInterval,
         animation: @escaping (AnimationState) -> Void) {
             let id = UUID().uuidString

SwiftWisdom/Core/UIKit/UIButton+AttributedTitle.swift

@@ -10,6 +10,7 @@ import UIKit
 
 public extension UIButton {
 
+    //swiftlint:disable function_default_parameter_at_end
     /**
      This will use existing attributes on the attributed text, plus the spacing passed in and apply 
      them to the string passed in.
@@ -30,4 +31,5 @@ public extension UIButton {
         }
         setAttributedTitle(spacedText, for: state)
     }
+    //swiftlint:enable function_default_parameter_at_end
 }

SwiftWisdom/Core/UIKit/UIView+Nib.swift

@@ -13,11 +13,14 @@ public extension UIView {
         return ip_fromNib(nibNameOrNil, type: self)
     }
 
+    //swiftlint:disable function_default_parameter_at_end
     class func ip_fromNib<T: UIView>(_ nibNameOrNil: String? = nil, type: T.Type) -> T {
-        let v: T? = ip_fromNib(nibNameOrNil, type: T.self)
-        return v!
+        let view: T? = ip_fromNib(nibNameOrNil, type: T.self)
+        return view!
     }
+    //swiftlint:enable function_default_parameter_at_end
 
+    //swiftlint:disable function_default_parameter_at_end
     class func ip_fromNib<T: UIView>(_ nibNameOrNil: String? = nil, type: T.Type) -> T? {
         var view: T?
         let name: String
@@ -28,13 +31,14 @@ public extension UIView {
             name = ip_nibName
         }
         let nibViews = Bundle.main.loadNibNamed(name, owner: nil, options: nil)
-        for v in nibViews ?? [] {
-            if let tog = v as? T {
+        for thisView in nibViews ?? [] {
+            if let tog = thisView as? T {
                 view = tog
             }
         }
         return view
     }
+    //swiftlint:enable function_default_parameter_at_end
 
     class var ip_nibName: String {
         let name = "\(self)".components(separatedBy: ".").first ?? ""

SwiftWisdom/Rx/Rx+Extensions.swift

@@ -9,6 +9,8 @@
 import RxSwift
 import RxCocoa
 
+//swiftlint:disable static_operator
+
 precedencegroup Binding {
     associativity: left
     higherThan: Disposing